Re: [RESEND,PATCH net-next v9 5/6] net: ngbe: add sriov function support

[Simon Horman <horms@kernel.org>]

On Tue, Mar 25, 2025 at 10:36:00AM +0800, mengyuanlou@net-swift.com wrote:
> > 2025年3月25日 03:21，Simon Horman <horms@kernel.org> 写道：
> > On Mon, Mar 24, 2025 at 10:00:32AM +0800, Mengyuan Lou wrote:

...

> That’s right.
> > If so, I believe this addresses Jakub's concerns.
> > 
> > And given that we are at v9 and the last feedback of substance was the
> > above comment from Jakub, I think this looks good.
> > 
> > Reviewed-by: Simon Horman <horms@kernel.org>
> > 
> > But I would like to say that there could be some follow-up to align
> > the comment and the names of the handlers:
> > 
> > * "other" seems to be used as a synonym for "misc".
> >  Perhaps ngbe_msix_misc() ?
> > * "common" seems to only process "misc" interrupts.
> >  Perhaps __ngbe_msix_misc() ?
> > * msic seems to be a misspelling of misc.
> > 
> 
> 
> >> +static irqreturn_t ngbe_msix_misc(int __always_unused irq, void *data)
> >> +{
> >>  ...
> >> + return __ngbe_msix_misc(wx, eicr);
> >> +}
> >> +
> >> +static irqreturn_t ngbe_misc_and_queue(int __always_unused irq, void *data)
> >> +{
> >>  ...
> >> + return __ngbe_msix_misc(wx, eicr);
> 
> 
> if (wx->num_vfs == 7)
> 	err = request_irq(wx->msix_entry->vector,
> 			  ngbe_misc_and_queue, 0, netdev->name, wx);
> else
> 	err = request_irq(wx->msix_entry->vector,
> 			  ngbe_msix_misc, 0, netdev->name, wx);
> 
> It’s more appropriate.
> 
> Thanks！

Yes, thanks.

And I also think it would also be nice to rename ngbe_msix_common()
as __ngbe_msix_misc().

But please hold off with any updates or follow-up as net-next is now closed
for the merge window.

Link: https://lore.kernel.org/netdev/20250324075539.2b60eb42@kernel.org/

...