From: Simon Horman <horms@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
"Arun Ramadoss" <arun.ramadoss@microchip.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
"Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH net v1 1/1] net: dsa: microchip: fix DCB apptrust configuration on KSZ88x3
Date: Tue, 25 Mar 2025 15:34:55 +0000 [thread overview]
Message-ID: <20250325153455.GV892515@horms.kernel.org> (raw)
In-Reply-To: <20250321141044.2128973-1-o.rempel@pengutronix.de>
On Fri, Mar 21, 2025 at 03:10:44PM +0100, Oleksij Rempel wrote:
> Remove KSZ88x3-specific priority and apptrust configuration logic that was
> based on incorrect register access assumptions. Also fix the register
> offset for KSZ8_REG_PORT_1_CTRL_0 to align with get_port_addr() logic.
>
> The KSZ88x3 switch family uses a different register layout compared to
> KSZ9477-compatible variants. Specifically, port control registers need
> offset adjustment through get_port_addr(), and do not match the datasheet
> values directly.
>
> Commit a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for
> KSZ88X3 family") introduced quirks based on datasheet offsets, which do
> not work with the driver's internal addressing model. As a result, these
> quirks addressed the wrong ports and caused unstable behavior.
>
> This patch removes all KSZ88x3-specific DCB quirks and corrects the port
> control register offset, effectively restoring working and predictable
> apptrust configuration.
>
> Fixes: a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for KSZ88X3 family")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-03-25 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 14:10 [PATCH net v1 1/1] net: dsa: microchip: fix DCB apptrust configuration on KSZ88x3 Oleksij Rempel
2025-03-25 15:34 ` Simon Horman [this message]
2025-03-25 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325153455.GV892515@horms.kernel.org \
--to=horms@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=san@skov.dk \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).