From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Naseef <naseefkm@gmail.com>
Cc: asmadeus@codewreck.org, andrew+netdev@lunn.ch,
davem@davemloft.net, dominique.martinet@atmark-techno.com,
edumazet@google.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
oneukum@suse.com, pabeni@redhat.com
Subject: Re: [PATCH] net: usb: usbnet: restore usb%d name exception for local mac addresses
Date: Wed, 26 Mar 2025 04:11:58 -0700 [thread overview]
Message-ID: <20250326041158.630cfdf7@kernel.org> (raw)
In-Reply-To: <20250326072726.1138-1-naseefkm@gmail.com>
On Wed, 26 Mar 2025 11:27:26 +0400 Ahmed Naseef wrote:
> Hello,
>
> I have tested this patch and can confirm that it works as expected with at least three models
> of Quectel LTE modems.
>
>
> Tested-by: Ahmed Naseef <naseefkm@gmail.com>
>
> This issue affects many users of OpenWrt, where USB LTE modems are widely used. The device
> name change has caused significant inconvenience, and as a result, this patch has already been
> accepted in OpenWrt:
>
> https://github.com/openwrt/openwrt/commit/ecd609f509f29ed1f75db5c7a623f359c64efb72
>
> Restoring the previous naming convention at the kernel level would greatly help in maintaining
> consistency and avoiding unnecessary workarounds in userspace which is not straightforward in openwrt.
>
> I hope this feedback helps in reconsidering the patch for mainline inclusion.
It needs to be reposted to be reconsidered, FWIW
next prev parent reply other threads:[~2025-03-26 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 13:04 [PATCH] net: usb: usbnet: restore usb%d name exception for local mac addresses Dominique Martinet
2024-12-03 14:48 ` Greg KH
2024-12-03 20:47 ` Andrew Lunn
2024-12-04 2:13 ` Jakub Kicinski
2024-12-05 9:16 ` Dominique Martinet
2024-12-05 14:51 ` Andrew Lunn
2025-03-26 7:27 ` Ahmed Naseef
2025-03-26 11:11 ` Jakub Kicinski [this message]
2025-03-26 11:34 ` Dominique Martinet
2025-03-26 11:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326041158.630cfdf7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=dominique.martinet@atmark-techno.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=naseefkm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).