From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D83A15278E; Wed, 26 Mar 2025 11:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742988229; cv=none; b=YEAGzb+uECaPlMy0okmm26hsV4v90Rg38UwjeDMjcqFA8Ajnzx7Tj9zMGg+V4wO1EmuYaxTcHncX3j66oCkIMDub4ZTLmy2v981rSc818x5Sz3wGgvt9P92+uYqk/Yf7EafktgT3m2ze9zmg5gfz6CgCE04e+xZnnov+lkLz6tU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742988229; c=relaxed/simple; bh=R4BP1NptH+VhMdTtTgYwlNby7+SvfPrG7xuFOaIwVAU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BsR4O6xHecz3se9xm9+/b6Lkf+fZMohqh9xgyx5OphTvsSQbpTxApY7h+kWF28uNWHed0CENNmWAIO5DpTYHDX6H6YncGPWQXYkSJ+z6NzcisNz3GupdU6GjfVIy/6LhCumsYnuZb9I8BhJmvEGNduvdG4oM/F59K3RcNRh7jPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fHyDTT3h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fHyDTT3h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 284B8C4CEE2; Wed, 26 Mar 2025 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742988229; bh=R4BP1NptH+VhMdTtTgYwlNby7+SvfPrG7xuFOaIwVAU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fHyDTT3hVuxBqyIU4oEseOMTj+c0VSHxKcZed0NNYmA8OSwZEWAgc0czFUZrjfiIh 7qgJWSXwRu1JFezkFTqyOMeCVvRlWfo3MOM2LQ6FZLD8kG9CMmdARLvg5K3HiM1EXM qH7tsj6QIkVsJjz2p9vc2e0qp2DD2cRUB7hv5mlr3HXcC9MIczwjX6a5ZdEajSspI/ KFSrtIwBx9RWXPKmVhZhdGTvbN58YkxQg11qW01Osi4T970lrdfdXamK8IDzLIQCRU evjIsSfOL5Po/jcZAKEqGd61AINteKB77XKZIxImWA2MlHI7tu66UeQ/5jW94bRPIN IPovHEz+vMqWw== Date: Wed, 26 Mar 2025 04:23:47 -0700 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v2 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap Message-ID: <20250326042347.279f23a8@kernel.org> In-Reply-To: <87cye4qkgd.fsf@toke.dk> References: <20250325-page-pool-track-dma-v2-0-113ebc1946f3@redhat.com> <20250325-page-pool-track-dma-v2-2-113ebc1946f3@redhat.com> <20250325151743.7ae425c3@kernel.org> <87cye4qkgd.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 26 Mar 2025 09:12:34 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > I don't see why we'd need to wipe them atomically. > > In fact I don't see why we're touching dma_sync_cpu, at all, > > it's driver-facing and the driver is gone in the problematic > > scenario. =20 >=20 > No you're right, but it felt weird to change just one of them, so > figured I'd go with both. But keeping them both as bool, and just making > dma_sync a full-width bool works, so I'll respin with that and leave > dma_sync_cpu as-is. Opinion on dma_sync_cpu clearing probably depends on mental model. No strong feelings but perhaps add a comment next to clearing it for the likes of myself saying that this technically shouldn't be needed as we only expect drivers to ask for CPU sync?