* [PATCH linux-next v2] net: atm: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().
@ 2025-03-25 2:28 xie.ludan
2025-03-26 7:22 ` xu.xin16
2025-03-26 11:45 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: xie.ludan @ 2025-03-25 2:28 UTC (permalink / raw)
To: davem, gerhard
Cc: edumazet, kuba, pabeni, horms, xie.ludan, netdev, linux-kernel,
xu.xin16, yang.yang29, ye.xingchen
From: XieLudan <xie.ludan@zte.com.cn>
Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.
Signed-off-by: XieLudan <xie.ludan@zte.com.cn>
---
v2:
- adapting the alignment of argument lines
net/atm/atm_sysfs.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c
index 54e7fb1a4ee5..726398fa848e 100644
--- a/net/atm/atm_sysfs.c
+++ b/net/atm/atm_sysfs.c
@@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type);
+ return sysfs_emit(buf, "%s\n", adev->type);
}
static ssize_t address_show(struct device *cdev,
@@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi);
+ return sysfs_emit(buf, "%pM\n", adev->esi);
}
static ssize_t atmaddress_show(struct device *cdev,
@@ -37,13 +37,12 @@ static ssize_t atmaddress_show(struct device *cdev,
spin_lock_irqsave(&adev->lock, flags);
list_for_each_entry(aaddr, &adev->local, entry) {
- count += scnprintf(buf + count, PAGE_SIZE - count,
- "%1phN.%2phN.%10phN.%6phN.%1phN\n",
- &aaddr->addr.sas_addr.prv[0],
- &aaddr->addr.sas_addr.prv[1],
- &aaddr->addr.sas_addr.prv[3],
- &aaddr->addr.sas_addr.prv[13],
- &aaddr->addr.sas_addr.prv[19]);
+ count += sysfs_emit_at(buf, count, "%1phN.%2phN.%10phN.%6phN.%1phN\n",
+ &aaddr->addr.sas_addr.prv[0],
+ &aaddr->addr.sas_addr.prv[1],
+ &aaddr->addr.sas_addr.prv[3],
+ &aaddr->addr.sas_addr.prv[13],
+ &aaddr->addr.sas_addr.prv[19]);
}
spin_unlock_irqrestore(&adev->lock, flags);
@@ -55,7 +54,7 @@ static ssize_t atmindex_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number);
+ return sysfs_emit(buf, "%d\n", adev->number);
}
static ssize_t carrier_show(struct device *cdev,
@@ -63,8 +62,7 @@ static ssize_t carrier_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%d\n",
- adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);
+ return sysfs_emit(buf, "%d\n", adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);
}
static ssize_t link_rate_show(struct device *cdev,
@@ -87,7 +85,7 @@ static ssize_t link_rate_show(struct device *cdev,
default:
link_rate = adev->link_rate * 8 * 53;
}
- return scnprintf(buf, PAGE_SIZE, "%d\n", link_rate);
+ return sysfs_emit(buf, "%d\n", link_rate);
}
static DEVICE_ATTR_RO(address);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next v2] net: atm: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().
2025-03-25 2:28 [PATCH linux-next v2] net: atm: use sysfs_emit()/sysfs_emit_at() instead of scnprintf() xie.ludan
@ 2025-03-26 7:22 ` xu.xin16
2025-03-26 11:45 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: xu.xin16 @ 2025-03-26 7:22 UTC (permalink / raw)
To: xie.ludan, davem, horms
Cc: gerhard, edumazet, kuba, pabeni, horms, xie.ludan, netdev,
linux-kernel, yang.yang29, ye.xingchen
>From: XieLudan <xie.ludan@zte.com.cn>
>
>Follow the advice in Documentation/filesystems/sysfs.rst:
>show() should only use sysfs_emit() or sysfs_emit_at() when formatting
>the value to be returned to user space.
>
>Signed-off-by: XieLudan <xie.ludan@zte.com.cn>
>---
>v2:
> - adapting the alignment of argument lines
> net/atm/atm_sysfs.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
>diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c
>index 54e7fb1a4ee5..726398fa848e 100644
>--- a/net/atm/atm_sysfs.c
>+++ b/net/atm/atm_sysfs.c
>@@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev,
> {
> struct atm_dev *adev = to_atm_dev(cdev);
>
>- return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type);
>+ return sysfs_emit(buf, "%s\n", adev->type);
> }
>
Generally LGTM. Thanks.
Reviewed-by: xu xin <xu.xin16@zte.com.cn>
> static ssize_t address_show(struct device *cdev,
>@@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev,
> {
> struct atm_dev *adev = to_atm_dev(cdev);
>
>- return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi);
>+ return sysfs_emit(buf, "%pM\n", adev->esi);
> }
>
> static ssize_t atmaddress_show(struct device *cdev,
>@@ -37,13 +37,12 @@ static ssize_t atmaddress_show(struct device *cdev,
>
> spin_lock_irqsave(&adev->lock, flags);
> list_for_each_entry(aaddr, &adev->local, entry) {
>- count += scnprintf(buf + count, PAGE_SIZE - count,
>- "%1phN.%2phN.%10phN.%6phN.%1phN\n",
>- &aaddr->addr.sas_addr.prv[0],
>- &aaddr->addr.sas_addr.prv[1],
>- &aaddr->addr.sas_addr.prv[3],
>- &aaddr->addr.sas_addr.prv[13],
>- &aaddr->addr.sas_addr.prv[19]);
>+ count += sysfs_emit_at(buf, count, "%1phN.%2phN.%10phN.%6phN.%1phN\n",
>+ &aaddr->addr.sas_addr.prv[0],
>+ &aaddr->addr.sas_addr.prv[1],
>+ &aaddr->addr.sas_addr.prv[3],
>+ &aaddr->addr.sas_addr.prv[13],
>+ &aaddr->addr.sas_addr.prv[19]);
> }
> spin_unlock_irqrestore(&adev->lock, flags);
>
>@@ -55,7 +54,7 @@ static ssize_t atmindex_show(struct device *cdev,
> {
> struct atm_dev *adev = to_atm_dev(cdev);
>
>- return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number);
>+ return sysfs_emit(buf, "%d\n", adev->number);
> }
>
> static ssize_t carrier_show(struct device *cdev,
>@@ -63,8 +62,7 @@ static ssize_t carrier_show(struct device *cdev,
> {
> struct atm_dev *adev = to_atm_dev(cdev);
>
>- return scnprintf(buf, PAGE_SIZE, "%d\n",
>- adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);
>+ return sysfs_emit(buf, "%d\n", adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);
> }
>
> static ssize_t link_rate_show(struct device *cdev,
>@@ -87,7 +85,7 @@ static ssize_t link_rate_show(struct device *cdev,
> default:
> link_rate = adev->link_rate * 8 * 53;
> }
>- return scnprintf(buf, PAGE_SIZE, "%d\n", link_rate);
>+ return sysfs_emit(buf, "%d\n", link_rate);
> }
>
> static DEVICE_ATTR_RO(address);
>--
>2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next v2] net: atm: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().
2025-03-25 2:28 [PATCH linux-next v2] net: atm: use sysfs_emit()/sysfs_emit_at() instead of scnprintf() xie.ludan
2025-03-26 7:22 ` xu.xin16
@ 2025-03-26 11:45 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-03-26 11:45 UTC (permalink / raw)
To: xie.ludan
Cc: davem, gerhard, edumazet, pabeni, horms, netdev, linux-kernel,
xu.xin16, yang.yang29, ye.xingchen
On Tue, 25 Mar 2025 10:28:05 +0800 (CST) xie.ludan@zte.com.cn wrote:
> From: XieLudan <xie.ludan@zte.com.cn>
>
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
## Form letter - net-next-closed
The merge window for v6.15 has begun and therefore net-next is closed for
new drivers, features, code refactoring and optimizations. We are currently
accepting bug fixes only.
Please repost when net-next reopens after Apr 7th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
pv-bot: closed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-25 2:28 [PATCH linux-next v2] net: atm: use sysfs_emit()/sysfs_emit_at() instead of scnprintf() xie.ludan
2025-03-26 7:22 ` xu.xin16
2025-03-26 11:45 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).