Re: [PATCH net-next v9 14/14] xsc: add ndo_get_stats64

[Simon Horman <horms@kernel.org>]

On Tue, Mar 18, 2025 at 11:15:24PM +0800, Xin Tian wrote:

...

> diff --git a/drivers/net/ethernet/yunsilicon/xsc/net/main.c b/drivers/net/ethernet/yunsilicon/xsc/net/main.c

...

> @@ -1912,14 +1931,20 @@ static int xsc_eth_probe(struct auxiliary_device *adev,
>  		goto err_nic_cleanup;
>  	}
>  
> +	adapter->stats = kvzalloc(sizeof(*adapter->stats), GFP_KERNEL);
> +	if (!adapter->stats)

Hi Xin Tian,

I think you need to set err to -ENOMEM here, else the function will return 0
even though a memory allocation error has occurred.

Flagged by Smatch (please consider running this tool on your patches).

> +		goto err_detach;
> +
>  	err = register_netdev(netdev);
>  	if (err) {
>  		netdev_err(netdev, "register_netdev failed, err=%d\n", err);
> -		goto err_detach;
> +		goto err_free_stats;
>  	}
>  
>  	return 0;
>  
> +err_free_stats:
> +	kvfree(adapter->stats);
>  err_detach:
>  	xsc_eth_detach(xdev, adapter);
>  err_nic_cleanup:

...