From: Jakub Kicinski <kuba@kernel.org>
To: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: Dmitry Safonov via B4 Relay
<devnull+0x7f454c46.gmail.com@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Date: Wed, 26 Mar 2025 13:00:05 -0700 [thread overview]
Message-ID: <20250326130005.0f12741d@kernel.org> (raw)
In-Reply-To: <CAJwJo6YoGz1aPv5nkJJKa05mxF-Zhc+B4U6kRw95KSduLCApaw@mail.gmail.com>
On Wed, 26 Mar 2025 19:48:16 +0000 Dmitry Safonov wrote:
> On Tue, 25 Mar 2025 at 13:15, Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 19 Mar 2025 03:13:33 +0000 Dmitry Safonov via B4 Relay wrote:
> > > Should fix flaky tcp-ao/connect-deny-ipv6 test.
> > > Begging pardon for the delay since the report and for sending it this
> > > late in the release cycle.
> >
> > Better late than never, thanks a lot! :)
>
> Thank you, Jakub!
>
> I also noticed that recently, self-connect-ipv6 became slightly flaky:
> https://netdev.bots.linux.dev/flakes.html?br-cnt=75&tn-needle=tcp-ao
>
> Seems unrelated to select()+poll selftests changes, but rather to
> timings in the kernel:
> # # 1249[lib/proc.c:213] Snmp6 Ip6OutNoRoutes: 0 => 1
>
> It seems that the test relied on kernel adding a link-local route with
> a loopback interface, but probably adding the interface got faster.
> Seems like a trivial two-line fix by manually adding the link-local
> route in userspace. Though, can't reproduce that flake locally on
> thousands of runs.
>
> Should I send the potential fix now for -net or wait until the merge
> window closes and send for -net-next?
I reckon you can send it now, maybe other maintainers will disagree
but to me test stability fixes should be okay during the MW.
You can tag it as net-next for the benefit of the build bot,
tho we'll end up merging it to net once/if Linus pulls.
next prev parent reply other threads:[~2025-03-26 20:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 3:13 [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 1/7] selftests/net: Print TCP flags in more common format Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 2/7] selftests/net: Provide tcp-ao counters comparison helper Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 3/7] selftests/net: Fetch and check TCP-MD5 counters Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 4/7] selftests/net: Add mixed select()+polling mode to TCP-AO tests Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 5/7] selftests/net: Print the testing side in unsigned-md5 Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 6/7] selftests/net: Delete timeout from test_connect_socket() Dmitry Safonov via B4 Relay
2025-03-19 3:13 ` [PATCH net-next v2 7/7] selftests/net: Drop timeout argument from test_client_verify() Dmitry Safonov via B4 Relay
2025-03-25 13:15 ` [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests Jakub Kicinski
2025-03-26 19:48 ` Dmitry Safonov
2025-03-26 20:00 ` Jakub Kicinski [this message]
2025-03-26 21:41 ` Dmitry Safonov
2025-03-25 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326130005.0f12741d@kernel.org \
--to=kuba@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=devnull+0x7f454c46.gmail.com@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).