[net PATCH] octeontx2-af: Fix mbox INTR handler when num VFs > 64

[net PATCH] octeontx2-af: Fix mbox INTR handler when num VFs > 64

[Geetha sowjanya]

When number of RVU VFs > 64, the vfs value passed to "rvu_queue_work" 
function is incorrect. Due to which mbox workqueue entries for
VFs 0 to 63 never gets added to workqueue.

Fixes: 9bdc47a6e328 ("octeontx2-af: Mbox communication support btw AF and it's VFs")
Signed-off-by: Geetha sowjanya <gakula@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index cd0d7b7774f1..6575c422635b 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -2634,7 +2634,7 @@ static irqreturn_t rvu_mbox_intr_handler(int irq, void *rvu_irq)
 		rvupf_write64(rvu, RVU_PF_VFPF_MBOX_INTX(1), intr);
 
 		rvu_queue_work(&rvu->afvf_wq_info, 64, vfs, intr);
-		vfs -= 64;
+		vfs = 64;
 	}
 
 	intr = rvupf_read64(rvu, RVU_PF_VFPF_MBOX_INTX(0));
-- 
2.25.1

Re: [net PATCH] octeontx2-af: Fix mbox INTR handler when num VFs > 64

[Simon Horman]

On Thu, Mar 27, 2025 at 02:44:41PM +0530, Geetha sowjanya wrote:
> When number of RVU VFs > 64, the vfs value passed to "rvu_queue_work" 
> function is incorrect. Due to which mbox workqueue entries for
> VFs 0 to 63 never gets added to workqueue.
> 
> Fixes: 9bdc47a6e328 ("octeontx2-af: Mbox communication support btw AF and it's VFs")
> Signed-off-by: Geetha sowjanya <gakula@marvell.com>

Reviewed-by: Simon Horman <horms@kernel.org>

I don't think you need to repost because of this,
but I do think this could have been a short series
including this patch and [1].

[1] [net PATCH] octeontx2-af: Free NIX_AF_INT_VEC_GEN irq
    https://lore.kernel.org/all/20250327094054.2312-1-gakula@marvell.com/

Re: [net PATCH] octeontx2-af: Fix mbox INTR handler when num VFs > 64

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 27 Mar 2025 14:44:41 +0530 you wrote:
> When number of RVU VFs > 64, the vfs value passed to "rvu_queue_work"
> function is incorrect. Due to which mbox workqueue entries for
> VFs 0 to 63 never gets added to workqueue.
> 
> Fixes: 9bdc47a6e328 ("octeontx2-af: Mbox communication support btw AF and it's VFs")
> Signed-off-by: Geetha sowjanya <gakula@marvell.com>
> 
> [...]

Here is the summary with links:
  - [net] octeontx2-af: Fix mbox INTR handler when num VFs > 64
    https://git.kernel.org/netdev/net/c/0fdba88a2115

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html