netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "mowenroot@163.com" <mowenroot@163.com>
To: "Paul Moore" <paul@paul-moore.com>,
	 "Jakub Kicinski" <kuba@kernel.org>,
	 netdev <netdev@vger.kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	 "Bitao  Ouyang" <1985755126@qq.com>
Subject: Fw:  [PATCH] netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets
Date: Thu, 27 Mar 2025 11:04:53 +0800	[thread overview]
Message-ID: <2025032711045196042914@163.com> (raw)

On Thu, Mar 27, 2025 at 3:38 AM Paul Moore paul@paul-moore.com wrote:

> For all three function, I'd probably add a single blank line between the local variable declarations and the code below for the sake of readability. I'd probably also drop the comment as the code seems reasonably obvious (inet6_sk() can return NULL, we can't do anything with a NULL ptr so bail), but neither are reasons for not applying this patch, if anything they can be fixed up during the merge assuming the patch author agrees.
>
> Anyway, this looks good to me, Jakub and/or other netdev folks, we should get this marked for stable and sent up to Linus, do you want to do that or should I?

Thank you for your acknowledgment and suggestions! Your insights have been very helpful to us.

We fully agree with your suggestions regarding code formatting and comment adjustments. Since you are more familiar with the code, we would appreciate it if you could help handle these modifications and complete the merge. If you are willing to do so, we would be very grateful!

Previously, the email failed to be delivered to netdev@vger.kernel.org and linux-kernel@vger.kernel.org due to formatting issues. We sincerely apologize for any inconvenience this may have caused.

Thank you again for your guidance and support. We are delighted to learn from you!

Thanks again.
 Debin Zhu & Bitao Ouyang

             reply	other threads:[~2025-03-27  3:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27  3:04 mowenroot [this message]
2025-03-28 15:50 ` Fw: [PATCH] netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025032711045196042914@163.com \
    --to=mowenroot@163.com \
    --cc=1985755126@qq.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).