Re: [PATCH] netlabel: Fix NULL pointer exception caused by CALIPSO on IPv4 sockets

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 26 Mar 2025 15:38:25 -0400 Paul Moore wrote:
> For all three function, I'd probably add a single blank line between
> the local variable declarations and the code below for the sake of
> readability.  I'd probably also drop the comment as the code seems
> reasonably obvious (inet6_sk() can return NULL, we can't do anything
> with a NULL ptr so bail), but neither are reasons for not applying
> this patch, if anything they can be fixed up during the merge assuming
> the patch author agrees.
> 
> Anyway, this looks good to me, Jakub and/or other netdev folks, we
> should get this marked for stable and sent up to Linus, do you want to
> do that or should I?

Thanks for the CC! Feel free to take it to Linus if you're happy with
it. We don't have the posting on the list so it'd be minor pain to apply.

As you say the safety check is probably okay, tho, it's unclear from 
the commit message and comment how we get here with a v4 socket or
perhaps not a fullsock..