netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Stanislav Fomichev <sdf@fomichev.me>, netdev@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev_init
Date: Sun, 30 Mar 2025 05:49:35 +0800	[thread overview]
Message-ID: <202503300552.i2jDOcpl-lkp@intel.com> (raw)
In-Reply-To: <20250329185704.676589-2-sdf@fomichev.me>

Hi Stanislav,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/net-switch-to-netif_disable_lro-in-inetdev_init/20250330-030132
base:   net/main
patch link:    https://lore.kernel.org/r/20250329185704.676589-2-sdf%40fomichev.me
patch subject: [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev_init
config: s390-randconfig-002-20250330 (https://download.01.org/0day-ci/archive/20250330/202503300552.i2jDOcpl-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250330/202503300552.i2jDOcpl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503300552.i2jDOcpl-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/core/dev.c:1774:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
   EXPORT_IPV6_MOD(netif_disable_lro);
   ^
   int
>> net/core/dev.c:1774:17: error: a parameter list without types is only allowed in a function definition
   EXPORT_IPV6_MOD(netif_disable_lro);
                   ^
   2 errors generated.


vim +/int +1774 net/core/dev.c

  1756	
  1757	void netif_disable_lro(struct net_device *dev)
  1758	{
  1759		struct net_device *lower_dev;
  1760		struct list_head *iter;
  1761	
  1762		dev->wanted_features &= ~NETIF_F_LRO;
  1763		netdev_update_features(dev);
  1764	
  1765		if (unlikely(dev->features & NETIF_F_LRO))
  1766			netdev_WARN(dev, "failed to disable LRO!\n");
  1767	
  1768		netdev_for_each_lower_dev(dev, lower_dev, iter) {
  1769			netdev_lock_ops(lower_dev);
  1770			netif_disable_lro(lower_dev);
  1771			netdev_unlock_ops(lower_dev);
  1772		}
  1773	}
> 1774	EXPORT_IPV6_MOD(netif_disable_lro);
  1775	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-03-29 21:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-29 18:56 [PATCH net v3 00/11] net: hold instance lock during NETDEV_UP/REGISTER Stanislav Fomichev
2025-03-29 18:56 ` [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev_init Stanislav Fomichev
2025-03-29 21:17   ` kernel test robot
2025-03-29 21:49   ` kernel test robot [this message]
2025-03-29 18:56 ` [PATCH net v3 02/11] net: hold instance lock during NETDEV_REGISTER/UP Stanislav Fomichev
2025-03-29 18:56 ` [PATCH net v3 03/11] net: use netif_disable_lro in ipv6_add_dev Stanislav Fomichev
2025-03-29 18:56 ` [PATCH net v3 04/11] net: rename rtnl_net_debug to lock_debug Stanislav Fomichev
2025-03-29 18:56 ` [PATCH net v3 05/11] netdevsim: add dummy device notifiers Stanislav Fomichev
2025-03-29 18:56 ` [PATCH net v3 06/11] net: dummy: request ops lock Stanislav Fomichev
2025-03-29 18:57 ` [PATCH net v3 07/11] docs: net: document netdev notifier expectations Stanislav Fomichev
2025-03-29 18:57 ` [PATCH net v3 08/11] selftests: net: use netdevsim in netns test Stanislav Fomichev
2025-03-29 18:57 ` [PATCH net v3 09/11] net: designate XSK pool pointers in queues as "ops protected" Stanislav Fomichev
2025-03-29 18:57 ` [PATCH net v3 10/11] netdev: add "ops compat locking" helpers Stanislav Fomichev
2025-03-29 18:57 ` [PATCH net v3 11/11] netdev: don't hold rtnl_lock over nl queue info get when possible Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202503300552.i2jDOcpl-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).