public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: pcs: lynx: fix phylink validation regression for phy-mode = "10g-qxgmii"
Date: Mon, 31 Mar 2025 18:54:36 +0300	[thread overview]
Message-ID: <20250331155436.zmor5g3h67773qcc@skbuf> (raw)
In-Reply-To: <Z-q44uKCRUtWmojl@shell.armlinux.org.uk>

On Mon, Mar 31, 2025 at 04:46:42PM +0100, Russell King (Oracle) wrote:
> On Mon, Mar 31, 2025 at 06:39:06PM +0300, Vladimir Oltean wrote:
> > Added by commit ce312bbc2351 ("net: pcs: lynx: accept phy-mode =
> > "10g-qxgmii" and use in felix driver"), this mode broke when the
> > lynx_interfaces[] array was introduced to populate
> > lynx->pcs.supported_interfaces, because it is absent from there.
> 
> This commit is not in net-next:
> 
> $ git log -p ce312bbc2351
> fatal: ambiguous argument 'ce312bbc2351': unknown revision or path not in the working tree.
> 
> Checking Linus' tree, it's the same.
> 
> Are you sure lynx in mainline supports this mode?
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Oops, you're right, please ignore me. I was working on a rebase and I
didn't even think to check whether the driver support for this new PHY
mode wasn't upstream. Now I'm starting to remember how the QCA8084 also
required it, and Luo Jie upstreamed the core support without users, and
without the Felix driver patch.

pw-bot: cr

  reply	other threads:[~2025-03-31 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 15:39 [PATCH net] net: pcs: lynx: fix phylink validation regression for phy-mode = "10g-qxgmii" Vladimir Oltean
2025-03-31 15:46 ` Russell King (Oracle)
2025-03-31 15:54   ` Vladimir Oltean [this message]
2025-03-31 16:04     ` Russell King (Oracle)
2025-03-31 19:44       ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250331155436.zmor5g3h67773qcc@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox