From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>, <willemdebruijn.kernel@gmail.com>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <horms@kernel.org>, <kuni1840@gmail.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v4 net 0/3] udp: Fix two integer overflows when sk->sk_rcvbuf is close to INT_MAX.
Date: Mon, 31 Mar 2025 16:29:41 -0700 [thread overview]
Message-ID: <20250331162941.01e14713@kernel.org> (raw)
In-Reply-To: <20250331203303.17835-1-kuniyu@amazon.com>
On Mon, 31 Mar 2025 13:31:47 -0700 Kuniyuki Iwashima wrote:
> > > Please do test locally if you can.
> >
> > Sure, will try the same tests with CI.
>
> Is there a way to tell NIPA to run a test in a dedicated VM ?
>
> I see some tests succeed when executed solely but fail when
> executed with
>
> make -C tools/testing/selftests/ TARGETS=net run_tests
>
> When combined with other tests, assuming that the global UDP usage
> will soon drop to 0 is not always easy... so it's defeating the
> purpose but I'd drop the test in v5 not to make CI unhappy.
Can we account for some level of system noise? Or try to dump all
the sockets and count the "accounted for" in-use memory?
We can do various things in NIPA, but I'm not sure if it's okay
for tests inside net/ should require a completely idle system.
If we want a completely idle system maybe user-mode Linux + kunit
is a better direction?
Willem, WDYT?
next prev parent reply other threads:[~2025-03-31 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 18:05 [PATCH v4 net 0/3] udp: Fix two integer overflows when sk->sk_rcvbuf is close to INT_MAX Kuniyuki Iwashima
2025-03-29 18:05 ` [PATCH v4 net 1/3] udp: Fix multiple wraparounds of sk->sk_rmem_alloc Kuniyuki Iwashima
2025-03-29 18:05 ` [PATCH v4 net 2/3] udp: Fix memory accounting leak Kuniyuki Iwashima
2025-03-29 18:05 ` [PATCH v4 net 3/3] selftest: net: Check wraparounds for sk->sk_rmem_alloc Kuniyuki Iwashima
2025-03-31 13:51 ` [PATCH v4 net 0/3] udp: Fix two integer overflows when sk->sk_rcvbuf is close to INT_MAX Jakub Kicinski
2025-03-31 18:21 ` Kuniyuki Iwashima
2025-03-31 18:36 ` Jakub Kicinski
2025-03-31 18:54 ` Kuniyuki Iwashima
2025-03-31 20:31 ` Kuniyuki Iwashima
2025-03-31 23:29 ` Jakub Kicinski [this message]
2025-04-01 1:15 ` Willem de Bruijn
2025-04-01 18:35 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331162941.01e14713@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).