From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <horms@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<kuni1840@gmail.com>, <kuniyu@amazon.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v1 net] rtnetlink: Use register_pernet_subsys() in rtnl_net_debug_init().
Date: Mon, 31 Mar 2025 11:25:27 -0700 [thread overview]
Message-ID: <20250331182532.1523-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250331154849.GC185681@horms.kernel.org>
From: Simon Horman <horms@kernel.org>
Date: Mon, 31 Mar 2025 16:48:49 +0100
> On Fri, Mar 28, 2025 at 03:04:48PM -0700, Kuniyuki Iwashima wrote:
> > rtnl_net_debug_init() registers rtnl_net_debug_net_ops by
> > register_pernet_device() but calls unregister_pernet_subsys()
> > in case register_netdevice_notifier() fails.
> >
> > It corrupts pernet_list because first_device is not updated
> > in unregister_pernet_device().
>
> Hi Iwashima-san,
>
> Maybe I am confused, but should the above line refer to
> unregister_pernet_subsys()?
Ah, exactly :)
>
> And perhaps it would be yet clearer to say something like:
>
> It corrupts pernet_list because first_device is not updated
> in register_pernet_device() but not unregister_pernet_subsys()?
Will rewrite in v2.
Thanks!
prev parent reply other threads:[~2025-03-31 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 22:04 [PATCH v1 net] rtnetlink: Use register_pernet_subsys() in rtnl_net_debug_init() Kuniyuki Iwashima
2025-03-31 15:48 ` Simon Horman
2025-03-31 18:25 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331182532.1523-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).