Re: [PATCH net] net: pcs: lynx: fix phylink validation regression for phy-mode = "10g-qxgmii"

Russell King (Oracle)
2025-03-31T16:04:28Z

On Mon, Mar 31, 2025 at 06:54:36PM +0300, Vladimir Oltean wrote:
> On Mon, Mar 31, 2025 at 04:46:42PM +0100, Russell King (Oracle) wrote:
> > On Mon, Mar 31, 2025 at 06:39:06PM +0300, Vladimir Oltean wrote:
> > > Added by commit ce312bbc2351 ("net: pcs: lynx: accept phy-mode =
> > > "10g-qxgmii" and use in felix driver"), this mode broke when the
> > > lynx_interfaces[] array was introduced to populate
> > > lynx->pcs.supported_interfaces, because it is absent from there.
> >
> > This commit is not in net-next:
> >
> > $ git log -p ce312bbc2351
> > fatal: ambiguous argument 'ce312bbc2351': unknown revision or path not in the working tree.
> >
> > Checking Linus' tree, it's the same.
> >
> > Are you sure lynx in mainline supports this mode?
> >
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
>
> Oops, you're right, please ignore me. I was working on a rebase and I
> didn't even think to check whether the driver support for this new PHY
> mode wasn't upstream. Now I'm starting to remember how the QCA8084 also
> required it, and Luo Jie upstreamed the core support without users, and
> without the Felix driver patch.

Oh no. A feature merged that didn't get any users, which happened six
months ago. :(

Can we please have a user of it in mainline soon?

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!