From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
yuyanghuang@google.com, jacob.e.keller@intel.com
Subject: Re: [PATCH net] netlink: specs: fix schema of rt_addr
Date: Tue, 1 Apr 2025 07:37:08 -0700 [thread overview]
Message-ID: <20250401073708.495798f3@kernel.org> (raw)
In-Reply-To: <m2msd0i8v9.fsf@gmail.com>
On Tue, 01 Apr 2025 09:28:10 +0100 Donald Hunter wrote:
> Fixes: 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support")
My bad!
> I wonder if the op name should be changed from getmaddrs to getmaddr,
> removing the plural to be consistent with do/dump conventions, or to
> getmulticast to be consistent with RTM_GETMULTICAST.
Well spotted! I have that change queued for net-next, but you're right,
we better send it as a fix, before too many people depend on it.
--
pw-bot: cr
prev parent reply other threads:[~2025-04-01 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 1:29 [PATCH net] netlink: specs: fix schema of rt_addr Jakub Kicinski
2025-04-01 2:40 ` Yuyang Huang
2025-04-01 8:28 ` Donald Hunter
2025-04-01 14:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401073708.495798f3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).