From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
ilias.apalodimas@linaro.org, dw@davidwei.uk,
netdev@vger.kernel.org, kuniyu@amazon.com, sdf@fomichev.me,
aleksander.lobakin@intel.com
Subject: Re: [RFC net-next 2/2] eth: bnxt: add support rx side device memory TCP
Date: Wed, 2 Apr 2025 05:46:16 -0700 [thread overview]
Message-ID: <20250402054616.4dc1c5b5@kernel.org> (raw)
In-Reply-To: <CAMArcTX1Q3Nx=GNiHHom=_P3A-jwT1gjpjh_yegj9CWkXbqvdg@mail.gmail.com>
On Wed, 2 Apr 2025 21:09:11 +0900 Taehee Yoo wrote:
> > Do we check if rx copybreak is enabled before allowing ZC to be enabled?
> > We can't copybreak with unreadable memory.
>
> For the bnxt driver, only the first page's data is copied by rx-copybreak.
> agg buffers are not affected by rx-copybreak.
> So I think it's okay.
> I tested rx-copybreak+devmem TCP, and it works well.
> 0 ~ 1024 rx-copybreak and from very small MTU to large MTU.
Ah, good point!
next prev parent reply other threads:[~2025-04-02 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 11:47 [RFC net-next 0/2]eth: bnxt: Implement rx-side device memory Taehee Yoo
2025-03-31 11:47 ` [RFC net-next 1/2] eth: bnxt: refactor buffer descriptor Taehee Yoo
2025-03-31 17:34 ` Jakub Kicinski
2025-04-01 6:48 ` Taehee Yoo
2025-04-01 5:39 ` Michael Chan
2025-04-01 7:17 ` Taehee Yoo
2025-04-01 15:22 ` David Wei
2025-04-01 15:20 ` David Wei
2025-03-31 11:47 ` [RFC net-next 2/2] eth: bnxt: add support rx side device memory TCP Taehee Yoo
2025-03-31 18:50 ` Jakub Kicinski
2025-04-02 12:09 ` Taehee Yoo
2025-04-02 12:46 ` Jakub Kicinski [this message]
2025-04-02 22:11 ` Mina Almasry
2025-04-02 22:45 ` Jakub Kicinski
2025-04-02 22:16 ` Mina Almasry
2025-04-03 1:55 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402054616.4dc1c5b5@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuniyu@amazon.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).