From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com,
wangpeiyang1@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/7] net: hibmcge: fix incorrect pause frame statistics issue
Date: Wed, 2 Apr 2025 19:56:04 +0100 [thread overview]
Message-ID: <20250402185604.GU214849@horms.kernel.org> (raw)
In-Reply-To: <20250402133905.895421-2-shaojijie@huawei.com>
On Wed, Apr 02, 2025 at 09:38:59PM +0800, Jijie Shao wrote:
> The driver supports pause frames,
> but does not pass pause frames based on rx pause enable configuration,
> resulting in incorrect pause frame statistics.
I think it would be worth explaining why pause frames need
to be passed through in order for statistics to be correct.
I.e. which entity is passing them through to which other
entity that counts them.
> This patch fixes this problem.
>
> Fixes: 3a03763f3876 ("net: hibmcge: Add pauseparam supported in this module")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
...
next prev parent reply other threads:[~2025-04-02 18:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 13:38 [PATCH net 0/7] There are some bugfix for hibmcge driver Jijie Shao
2025-04-02 13:38 ` [PATCH net 1/7] net: hibmcge: fix incorrect pause frame statistics issue Jijie Shao
2025-04-02 18:56 ` Simon Horman [this message]
2025-04-03 1:34 ` Jijie Shao
2025-04-02 13:39 ` [PATCH net 2/7] net: hibmcge: fix incorrect multicast filtering issue Jijie Shao
2025-04-02 18:56 ` Simon Horman
2025-04-02 13:39 ` [PATCH net 3/7] net: hibmcge: fix the share of irq statistics among different network ports issue Jijie Shao
2025-04-02 18:57 ` Simon Horman
2025-04-02 13:39 ` [PATCH net 4/7] net: hibmcge: fix wrong mtu log issue Jijie Shao
2025-04-02 18:58 ` Simon Horman
2025-04-02 13:39 ` [PATCH net 5/7] net: hibmcge: fix the incorrect np_link fail state issue Jijie Shao
2025-04-02 19:04 ` Simon Horman
2025-04-02 13:39 ` [PATCH net 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue Jijie Shao
2025-04-02 19:07 ` Simon Horman
2025-04-02 13:39 ` [PATCH net 7/7] net: hibmcge: fix multiple phy_stop() issue Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402185604.GU214849@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).