From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
yuyanghuang@google.com, jacob.e.keller@intel.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net v3 2/4] netlink: specs: rt_addr: fix get multi command name
Date: Wed, 2 Apr 2025 18:37:04 -0700 [thread overview]
Message-ID: <20250403013706.2828322-3-kuba@kernel.org> (raw)
In-Reply-To: <20250403013706.2828322-1-kuba@kernel.org>
Command names should match C defines, codegens may depend on it.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Fixes: 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v3:
- fix the op name in the test
v2: https://lore.kernel.org/20250402010300.2399363-3-kuba@kernel.org
---
Documentation/netlink/specs/rt_addr.yaml | 2 +-
tools/testing/selftests/net/rtnetlink.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml
index 3bc9b6f9087e..1650dc3f091a 100644
--- a/Documentation/netlink/specs/rt_addr.yaml
+++ b/Documentation/netlink/specs/rt_addr.yaml
@@ -169,7 +169,7 @@ protonum: 0
value: 20
attributes: *ifaddr-all
-
- name: getmaddrs
+ name: getmulticast
doc: Get / dump IPv4/IPv6 multicast addresses.
attribute-set: addr-attrs
fixed-header: ifaddrmsg
diff --git a/tools/testing/selftests/net/rtnetlink.py b/tools/testing/selftests/net/rtnetlink.py
index 80950888800b..69436415d56e 100755
--- a/tools/testing/selftests/net/rtnetlink.py
+++ b/tools/testing/selftests/net/rtnetlink.py
@@ -12,7 +12,7 @@ IPV4_ALL_HOSTS_MULTICAST = b'\xe0\x00\x00\x01'
At least the loopback interface should have this address.
"""
- addresses = rtnl.getmaddrs({"ifa-family": socket.AF_INET}, dump=True)
+ addresses = rtnl.getmulticast({"ifa-family": socket.AF_INET}, dump=True)
all_host_multicasts = [
addr for addr in addresses if addr['ifa-multicast'] == IPV4_ALL_HOSTS_MULTICAST
--
2.49.0
next prev parent reply other threads:[~2025-04-03 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 1:37 [PATCH net v3 0/4] netlink: specs: rt_addr: fix problems revealed by C codegen Jakub Kicinski
2025-04-03 1:37 ` [PATCH net v3 1/4] netlink: specs: rt_addr: fix the spec format / schema failures Jakub Kicinski
2025-04-03 1:37 ` Jakub Kicinski [this message]
2025-04-03 8:34 ` [PATCH net v3 2/4] netlink: specs: rt_addr: fix get multi command name Donald Hunter
2025-04-03 1:37 ` [PATCH net v3 3/4] netlink: specs: rt_addr: pull the ifa- prefix out of the names Jakub Kicinski
2025-04-03 8:36 ` Donald Hunter
2025-04-03 1:37 ` [PATCH net v3 4/4] netlink: specs: rt_route: " Jakub Kicinski
2025-04-03 8:37 ` Donald Hunter
2025-04-04 15:10 ` [PATCH net v3 0/4] netlink: specs: rt_addr: fix problems revealed by C codegen patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403013706.2828322-3-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).