From: Jakub Kicinski <kuba@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] sfc: Add error handling for devlink_info_serial_number_put()
Date: Thu, 3 Apr 2025 15:17:35 -0700 [thread overview]
Message-ID: <20250403151735.69461ade@kernel.org> (raw)
In-Reply-To: <20250401130557.2515-1-vulab@iscas.ac.cn>
On Tue, 1 Apr 2025 21:05:57 +0800 Wentao Liang wrote:
> if (!rc) {
> snprintf(sn, EFX_MAX_SERIALNUM_LEN, "%pm", mac_address);
> - devlink_info_serial_number_put(req, sn);
> + err = devlink_info_serial_number_put(req, sn);
> + if (err)
> + return err;
Why are you introducing another variable? You can do this:
if (rc)
return rc;
snprintf...
return devlink_info..
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-03 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 13:05 [PATCH] sfc: Add error handling for devlink_info_serial_number_put() Wentao Liang
2025-04-03 22:17 ` Jakub Kicinski [this message]
2025-04-07 8:48 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403151735.69461ade@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).