* [PATCH] Remove __get_unaligned_cpu32 from netronome drivers
@ 2025-04-03 9:07 Julian Vetter
2025-04-03 23:21 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Julian Vetter @ 2025-04-03 9:07 UTC (permalink / raw)
To: Arnd Bergmann, Louis Peens, Jakub Kicinski, Andrew Lunn,
David S . Miller, Eric Dumazet, Paolo Abeni, Shannon Nelson,
Vladimir Oltean, Arthur Kiyanovski, Caleb Sander Mateos,
Florian Fainelli
Cc: oss-drivers, netdev, linux-kernel, Julian Vetter
The __{get,put}_unaligned_cpu{16,32,64} functions are deprecated, and
only a small number of drivers still use them. So, replace it here with
the more generic get_unaligned() function and just cast the input
parameter.
Signed-off-by: Julian Vetter <julian@outer-limits.org>
---
drivers/net/ethernet/netronome/nfp/nfd3/dp.c | 2 +-
drivers/net/ethernet/netronome/nfp/nfdk/dp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfd3/dp.c b/drivers/net/ethernet/netronome/nfp/nfd3/dp.c
index f1c6c47564b1..08086eb76996 100644
--- a/drivers/net/ethernet/netronome/nfp/nfd3/dp.c
+++ b/drivers/net/ethernet/netronome/nfp/nfd3/dp.c
@@ -779,7 +779,7 @@ nfp_nfd3_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta,
case NFP_NET_META_CSUM:
meta->csum_type = CHECKSUM_COMPLETE;
meta->csum =
- (__force __wsum)__get_unaligned_cpu32(data);
+ (__force __wsum)get_unaligned((u32 *)data);
data += 4;
break;
case NFP_NET_META_RESYNC_INFO:
diff --git a/drivers/net/ethernet/netronome/nfp/nfdk/dp.c b/drivers/net/ethernet/netronome/nfp/nfdk/dp.c
index ebeb6ab4465c..ab3cd06ed63e 100644
--- a/drivers/net/ethernet/netronome/nfp/nfdk/dp.c
+++ b/drivers/net/ethernet/netronome/nfp/nfdk/dp.c
@@ -779,7 +779,7 @@ nfp_nfdk_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta,
case NFP_NET_META_CSUM:
meta->csum_type = CHECKSUM_COMPLETE;
meta->csum =
- (__force __wsum)__get_unaligned_cpu32(data);
+ (__force __wsum)get_unaligned((u32 *)data);
data += 4;
break;
case NFP_NET_META_RESYNC_INFO:
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Remove __get_unaligned_cpu32 from netronome drivers
2025-04-03 9:07 [PATCH] Remove __get_unaligned_cpu32 from netronome drivers Julian Vetter
@ 2025-04-03 23:21 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-04-03 23:21 UTC (permalink / raw)
To: Julian Vetter
Cc: Arnd Bergmann, Louis Peens, Andrew Lunn, David S . Miller,
Eric Dumazet, Paolo Abeni, Shannon Nelson, Vladimir Oltean,
Arthur Kiyanovski, Caleb Sander Mateos, Florian Fainelli,
oss-drivers, netdev, linux-kernel
On Thu, 3 Apr 2025 11:07:43 +0200 Julian Vetter wrote:
> Subject: [PATCH] Remove __get_unaligned_cpu32 from netronome drivers
Since the merge window is still ongoing we don't accept code cleanups:
https://netdev.bots.linux.dev/net-next.html
Could you repost on Monday with the right subject prefix?
eth: nfp: remove __get_unaligned_cpu32 from netronome drivers
--
pw-bot: defer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-03 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 9:07 [PATCH] Remove __get_unaligned_cpu32 from netronome drivers Julian Vetter
2025-04-03 23:21 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).