From: Simon Horman <horms@kernel.org>
To: Chen Linxuan <chenlinxuan@uniontech.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH] docs: tproxy: fix formatting for nft code block
Date: Mon, 7 Apr 2025 15:49:45 +0100 [thread overview]
Message-ID: <20250407144945.GL395307@horms.kernel.org> (raw)
In-Reply-To: <CFD0AAF9D7040B1E+20250407031727.1615941-1-chenlinxuan@uniontech.com>
+ Pablo, Jozsef, netfilter-devel, coreteam
On Mon, Apr 07, 2025 at 11:17:27AM +0800, Chen Linxuan wrote:
Hi Chen,
A description of why this change is being made should go here.
As this is a patch for Netfilter documentation, it should probably be
targeted at nf-next like this:
Subject: [PATCH nf-next] ...
And Pablo, Jozsef, netfilter-devel and coreteam should be CCed.
If you do post a follow-up, please do allow 24h between it and your
original post as per:
https://docs.kernel.org/process/maintainer-netdev.html
The documentation update itself looks good to me.
Pablo and Jozef,
Should we add tproxy.rst to the MAINTAINERS entry for NETFILTER
so that get_maintainer.pl does the right thing?
> Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> ---
> Documentation/networking/tproxy.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/tproxy.rst b/Documentation/networking/tproxy.rst
> index 7f7c1ff6f159..75e4990cc3db 100644
> --- a/Documentation/networking/tproxy.rst
> +++ b/Documentation/networking/tproxy.rst
> @@ -69,9 +69,9 @@ add rules like this to the iptables ruleset above::
> # iptables -t mangle -A PREROUTING -p tcp --dport 80 -j TPROXY \
> --tproxy-mark 0x1/0x1 --on-port 50080
>
> -Or the following rule to nft:
> +Or the following rule to nft::
>
> -# nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
> + # nft add rule filter divert tcp dport 80 tproxy to :50080 meta mark set 1 accept
>
> Note that for this to work you'll have to modify the proxy to enable (SOL_IP,
> IP_TRANSPARENT) for the listening socket.
> --
> 2.48.1
>
next prev parent reply other threads:[~2025-04-07 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 3:17 [PATCH] docs: tproxy: fix formatting for nft code block Chen Linxuan
2025-04-07 14:49 ` Simon Horman [this message]
2025-04-08 0:47 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407144945.GL395307@horms.kernel.org \
--to=horms@kernel.org \
--cc=chenlinxuan@uniontech.com \
--cc=corbet@lwn.net \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).