Re: [PATCH net-next 10/12] afs: Use rxgk RESPONSE to pass token for callback channel

[Simon Horman <horms@kernel.org>]

On Mon, Apr 07, 2025 at 10:14:41AM +0100, David Howells wrote:
> Implement in kafs the hook for adding appdata into a RESPONSE packet
> generated in response to an RxGK CHALLENGE packet, and include the key for
> securing the callback channel so that notifications from the fileserver get
> encrypted.
> 
> This will be necessary when more complex notifications are used that convey
> changed data around.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

...

> diff --git a/fs/afs/cm_security.c b/fs/afs/cm_security.c

...

> +/*
> + * Create an YFS RxGK GSS token to use as a ticket to the specified fileserver.
> + */
> +static int afs_create_yfs_cm_token(struct sk_buff *challenge,
> +				   struct afs_server *server)
> +{

...

> +	if ((unsigned long)xdr - (unsigned long)appdata != adatasize)
> +		pr_err("Appdata size incorrect %zx != %zx\n",
> +		       (unsigned long)xdr - (unsigned long)appdata, adatasize);

Hi David,

x86_32 allmodconfig W=1 builds complain that:

warning: format ‘%zx’ expects argument of type ‘size_t’, but argument 2 has type ‘long unsigned int’ [-Wformat=]

...