From: Jakub Kicinski <kuba@kernel.org>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
netdev <netdev@vger.kernel.org>, Oliver Neukum <oneukum@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v2] usbnet: asix AX88772: leave the carrier control to phylink
Date: Tue, 8 Apr 2025 08:22:57 -0700 [thread overview]
Message-ID: <20250408082257.7281c61c@kernel.org> (raw)
In-Reply-To: <m3plhmdfte.fsf_-_@t19.piap.pl>
On Tue, 08 Apr 2025 13:59:41 +0200 Krzysztof Hałasa wrote:
> ASIX AX88772B based USB 10/100 Ethernet adapter doesn't come
> up ("carrier off"), despite the built-in 100BASE-FX PHY positive link
> indication. The internal PHY is configured (using EEPROM) in fixed
> 100 Mbps full duplex mode.
>
> The primary problem appears to be using carrier_netif_{on,off}() while,
> at the same time, delegating carrier management to phylink. Use only the
> latter and remove "manual control" in the asix driver.
>
> I don't have any other AX88772 board here, but the problem doesn't seem
> specific to a particular board or settings - it's probably
> timing-dependent.
>
> Remove unused asix_adjust_link() as well.
>
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
In the future, if you don't mind, please add a lore link here, like
this:
---
v1: https://lore.kernel.org/all/m35xjgdvih.fsf@t19.piap.pl/
Sending in-reply-to is discouraged, it messes up patch ordering for
reviewers:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review
next prev parent reply other threads:[~2025-04-08 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 12:08 [PATCH REPOST] usbnet: asix: leave the carrier control to phylink Krzysztof Hałasa
2025-04-07 13:38 ` Oleksij Rempel
2025-04-08 11:55 ` Krzysztof Hałasa
2025-04-08 11:59 ` [PATCH v2] usbnet: asix AX88772: " Krzysztof Hałasa
2025-04-08 15:22 ` Jakub Kicinski [this message]
2025-04-10 12:14 ` Oleksij Rempel
2025-04-11 2:20 ` patchwork-bot+netdevbpf
2025-04-08 13:29 ` [PATCH REPOST] usbnet: asix: " Paolo Abeni
2025-04-09 9:07 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408082257.7281c61c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jtornosm@redhat.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).