From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
john.fastabend@gmail.com, sdf@fomichev.me,
Willem de Bruijn <willemb@google.com>
Subject: [PATCH bpf v3 0/2] support SKF_NET_OFF and SKF_LL_OFF on skb frags
Date: Tue, 8 Apr 2025 09:27:47 -0400 [thread overview]
Message-ID: <20250408132833.195491-1-willemdebruijn.kernel@gmail.com> (raw)
From: Willem de Bruijn <willemb@google.com>
Address a longstanding issue that may lead to missed packets
depending on system configuration.
Ensure that reading from packet contents works regardless of skb
geometry, also when using the special SKF_.. negative offsets to
offset from L2 or L3 header.
Patch 2 is the selftest for the fix.
v2->v3
- do not remove bpf_internal_load_pointer_neg_helper, because it
is still used in the sparc32 JIT
v1->v2
- introduce bfp_skb_load_helper_convert_offset to avoid open
coding
- selftest: add comment why early demux must be disabled
v2: https://lore.kernel.org/netdev/20250404142633.1955847-1-willemdebruijn.kernel@gmail.com/
v1: https://lore.kernel.org/netdev/20250403140846.1268564-1-willemdebruijn.kernel@gmail.com/
Willem de Bruijn (2):
bpf: support SKF_NET_OFF and SKF_LL_OFF on skb frags
selftests/net: test sk_filter support for SKF_NET_OFF on frags
net/core/filter.c | 80 ++++---
tools/testing/selftests/net/.gitignore | 1 +
tools/testing/selftests/net/Makefile | 2 +
tools/testing/selftests/net/skf_net_off.c | 244 +++++++++++++++++++++
tools/testing/selftests/net/skf_net_off.sh | 30 +++
5 files changed, 321 insertions(+), 36 deletions(-)
create mode 100644 tools/testing/selftests/net/skf_net_off.c
create mode 100755 tools/testing/selftests/net/skf_net_off.sh
--
2.49.0.504.g3bcea36a83-goog
next reply other threads:[~2025-04-08 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 13:27 Willem de Bruijn [this message]
2025-04-08 13:27 ` [PATCH bpf v3 1/2] bpf: support SKF_NET_OFF and SKF_LL_OFF on skb frags Willem de Bruijn
2025-04-09 14:05 ` Stanislav Fomichev
2025-04-08 13:27 ` [PATCH bpf v3 2/2] selftests/net: test sk_filter support for SKF_NET_OFF on frags Willem de Bruijn
2025-04-10 3:10 ` [PATCH bpf v3 0/2] support SKF_NET_OFF and SKF_LL_OFF on skb frags patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408132833.195491-1-willemdebruijn.kernel@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).