From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4C9723FC4B for ; Tue, 8 Apr 2025 23:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744154714; cv=none; b=rcgOenC4BpT9Pz6NpyIi7L1agl8bdrQpjIT4mincZDHVj4JqznXO2Rd5T1jlx4GInqkMAX/kEE68KaJrEL8VgG6bE8my35hLrqSueDM517qJj4IB9fBC3YsF6GZin7k8KRyFtlzUyMyIonyDmzCQf6zEvoxlNZuaqouxrPhOECE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744154714; c=relaxed/simple; bh=V6qfC59SiIeXwHdFJLKnfdaNgDpZfwkPDBtUy9Pq4/8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IDt73BP2M+S6gGswYPEQYLa1nN7qsxpDWnrGbGCCkoHuNJuNeiKud4jYJ65xLofD35zpEP692tQ3znIpXHltGrXUUoB24nXwtuAjGFEH5sPNx+ot4LDwiy1SgZ/z2TEfLTx3p1Ik0bPfeXopaC8tj6qzZHrcnieRVK1uGkV3Cdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q7Kgnwi7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q7Kgnwi7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6DC0C4CEE5; Tue, 8 Apr 2025 23:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744154714; bh=V6qfC59SiIeXwHdFJLKnfdaNgDpZfwkPDBtUy9Pq4/8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q7Kgnwi7ii799IpfPEctRHrSCXulhn2vP+WUVBta0P3NxCqoMolzBzpaUlIEt1Mwu gJekQZ2X/7+daw6Cp+hSccrxpYCL5TiIsu1QYF5/H4j9WsCXFdXHOc3AfU/fvCXVcO +Tg1AO8nmzgqYqctKV6+7yEIquUG96U+t4Nl7Fgn9Pl0Ulpat2bMYN6Z96Ja9/mgdI BHf/OuIla7mE2q9+RWwA1XoWEgWTxZC+lS5AoEAJvMNWCb75ly3KqE+JT83mDJhV5C cbMJrBqRGrEuzBFrn+Iz2wor9VSN/pqwKDKhtgr+vEnCt9kMucbht57K98EcoObF/b 6oYZV4dpmV+zQ== Date: Tue, 8 Apr 2025 16:25:12 -0700 From: Jakub Kicinski To: Kuniyuki Iwashima Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , David Ahern , "Neal Cardwell" , Willem de Bruijn , "Pablo Neira Ayuso" , Jozsef Kadlecsik , Paul Moore , James Morris , "Serge E. Hallyn" , "Kuniyuki Iwashima" , Subject: Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP. Message-ID: <20250408162512.23a84b5e@kernel.org> In-Reply-To: <20250407231823.95927-4-kuniyu@amazon.com> References: <20250407231823.95927-1-kuniyu@amazon.com> <20250407231823.95927-4-kuniyu@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 7 Apr 2025 16:17:50 -0700 Kuniyuki Iwashima wrote: > DCCP was removed, so many inet functions no longer need to > be exported. > > Let's unexport or use EXPORT_IPV6_MOD() for such functions. > > sk_free_unlock_clone() is inlined in sk_clone_lock() as it's > the only caller. netfilter wants inet_twsk_put ERROR: modpost: "inet_twsk_put" [net/ipv4/netfilter/nf_tproxy_ipv4.ko] undefined! ERROR: modpost: "inet_twsk_put" [net/ipv6/netfilter/nf_tproxy_ipv6.ko] undefined! allmodconfig builds seems to miss it :( -- pw-bot: cr