From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kuba@kernel.org>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <horms@kernel.org>, <jmorris@namei.org>,
<kadlec@netfilter.org>, <kuni1840@gmail.com>, <kuniyu@amazon.com>,
<ncardwell@google.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <pablo@netfilter.org>, <paul@paul-moore.com>,
<serge@hallyn.com>, <willemb@google.com>
Subject: Re: [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP.
Date: Tue, 8 Apr 2025 16:53:02 -0700 [thread overview]
Message-ID: <20250408235316.13501-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250408162512.23a84b5e@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 8 Apr 2025 16:25:12 -0700
> On Mon, 7 Apr 2025 16:17:50 -0700 Kuniyuki Iwashima wrote:
> > DCCP was removed, so many inet functions no longer need to
> > be exported.
> >
> > Let's unexport or use EXPORT_IPV6_MOD() for such functions.
> >
> > sk_free_unlock_clone() is inlined in sk_clone_lock() as it's
> > the only caller.
>
> netfilter wants inet_twsk_put
>
> ERROR: modpost: "inet_twsk_put" [net/ipv4/netfilter/nf_tproxy_ipv4.ko] undefined!
> ERROR: modpost: "inet_twsk_put" [net/ipv6/netfilter/nf_tproxy_ipv6.ko] undefined!
>
> allmodconfig builds seems to miss it :(
Thanks for catching this!
I actually had ran allmodconfig but it couldn't catch it
because the error would be reproducible with IPV6=y.
I'll test allmodconfig + IPV6=y explicitly for v2.
next prev parent reply other threads:[~2025-04-08 23:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 23:17 [PATCH v1 net-next 0/4] net: Retire DCCP Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 1/4] selftest: net: Remove DCCP bits Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 2/4] net: Retire DCCP Kuniyuki Iwashima
2025-04-08 1:34 ` Paul Moore
2025-04-08 5:22 ` Christian Göttsche
2025-04-08 8:12 ` Paul Moore
2025-04-08 16:28 ` Casey Schaufler
2025-04-08 16:37 ` Pablo Neira Ayuso
2025-04-08 17:31 ` Kuniyuki Iwashima
2025-04-07 23:17 ` [PATCH v1 net-next 3/4] net: Unexport shared functions for DCCP Kuniyuki Iwashima
2025-04-08 23:25 ` Jakub Kicinski
2025-04-08 23:53 ` Kuniyuki Iwashima [this message]
2025-04-07 23:17 ` [PATCH v1 net-next 4/4] tcp: Rename tcp_or_dccp_get_hashinfo() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408235316.13501-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jmorris@namei.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).