From: Jakub Kicinski <kuba@kernel.org>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@intel.com>
Cc: "Nelson, Shannon" <shannon.nelson@amd.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"Dumazet, Eric" <edumazet@google.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"horms@kernel.org" <horms@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
"R, Bharath" <bharath.r@intel.com>
Subject: Re: [PATCH net-next 01/15] devlink: add value check to devlink_info_version_put()
Date: Wed, 9 Apr 2025 07:39:42 -0700 [thread overview]
Message-ID: <20250409073942.26be7914@kernel.org> (raw)
In-Reply-To: <DS0PR11MB7785945F6C0A9907A4E51AD6F0B42@DS0PR11MB7785.namprd11.prod.outlook.com>
On Wed, 9 Apr 2025 14:14:23 +0000 Jagielski, Jedrzej wrote:
> No insisting on that but should empty entry be really presented to the user?
> Especially unintentionally? Actually it's exposing some driver's shortcomings.
> That means the output was not properly validated so imho there's no point in
> printing it.
+1, FWIW, I don't see the point of outputting keys without values.
next prev parent reply other threads:[~2025-04-09 14:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 21:51 [PATCH net-next 00/15][pull request] ixgbe: Add basic devlink support Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 01/15] devlink: add value check to devlink_info_version_put() Tony Nguyen
2025-04-08 0:31 ` Nelson, Shannon
2025-04-08 11:00 ` Jagielski, Jedrzej
2025-04-08 16:24 ` Nelson, Shannon
2025-04-09 14:14 ` Jagielski, Jedrzej
2025-04-09 14:39 ` Jakub Kicinski [this message]
2025-04-09 17:25 ` Nelson, Shannon
2025-04-11 11:11 ` Edward Cree
2025-04-14 12:28 ` Przemek Kitszel
2025-04-14 16:33 ` Jakub Kicinski
2025-04-15 7:53 ` Przemek Kitszel
2025-04-07 21:51 ` [PATCH net-next 02/15] ixgbe: wrap netdev_priv() usage Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 03/15] ixgbe: add initial devlink support Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 04/15] ixgbe: add handler for devlink .info_get() Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 05/15] ixgbe: add E610 functions for acquiring flash data Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 06/15] ixgbe: read the OROM version information Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 07/15] ixgbe: read the netlist " Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 08/15] ixgbe: add .info_get extension specific for E610 devices Tony Nguyen
2025-04-09 2:28 ` Jakub Kicinski
2025-04-07 21:51 ` [PATCH net-next 09/15] ixgbe: add E610 functions getting PBA and FW ver info Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 10/15] ixgbe: extend .info_get with() stored versions Tony Nguyen
2025-04-09 2:31 ` Jakub Kicinski
2025-04-09 10:50 ` Jagielski, Jedrzej
2025-04-09 14:38 ` Jakub Kicinski
2025-04-10 12:49 ` Jagielski, Jedrzej
2025-04-07 21:51 ` [PATCH net-next 11/15] ixgbe: add device flash update via devlink Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 12/15] ixgbe: add support for devlink reload Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 13/15] ixgbe: add FW API version check Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 14/15] ixgbe: add E610 implementation of FW recovery mode Tony Nguyen
2025-04-07 21:51 ` [PATCH net-next 15/15] ixgbe: add support for FW rollback mode Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409073942.26be7914@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bharath.r@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jedrzej.jagielski@intel.com \
--cc=jiri@resnulli.us \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).