netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Cosmin Ratiu <cratiu@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"horms@kernel.org" <horms@kernel.org>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	"edumazet@google.com" <edumazet@google.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: net-shapers plan
Date: Wed, 9 Apr 2025 15:06:39 -0700	[thread overview]
Message-ID: <20250409150639.30a4c041@kernel.org> (raw)
In-Reply-To: <1fc5aaa2-1c3d-48cc-99a8-523ed82b4cf9@nvidia.com>

On Tue, 8 Apr 2025 17:43:19 +0300 Carolina Jubran wrote:
> >> I don't believe there's a specific real-world scenario. It's really
> >> about maximizing flexibility. Essentially, if a user sets things up in a
> >> less-than-optimal way, the hardware can ensure that traffic is
> >> classified and managed properly.  
> > 
> > I see. If you could turn it off and leave it out, at least until clear
> > user appears that'd be great. Reclassifying packets on Tx slightly goes
> > against the netdev recommendation to limit any packet parsing and
> > interpretation on Tx.  
> 
> The hardware enforces a match between the packet’s priority and the 
> scheduling queue’s configured priority. If they match, the packet is 
> transmitted without further processing. If not, the hardware moves the 
> Tx queue to the right scheduling queue to ensure proper traffic class 
> separation.
> This check is always active and cannot currently be disabled. Even when
> the queue is configured with the correct priority, the hardware still 
> verifies the match before sending.

It needs to work as intended :( so you probably need to enforce
the correct mapping in the FW or the driver.

  reply	other threads:[~2025-04-09 22:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 14:03 net-shapers plan Cosmin Ratiu
2025-03-11  1:42 ` Samudrala, Sridhar
2025-03-12 11:02   ` Carolina Jubran
2025-03-11 13:38 ` Jiri Pirko
2025-03-26 15:55   ` Cosmin Ratiu
2025-03-28 12:13 ` Jakub Kicinski
2025-04-01  8:35   ` Carolina Jubran
2025-04-01 14:50     ` Jakub Kicinski
2025-04-08 14:43       ` Carolina Jubran
2025-04-09 22:06         ` Jakub Kicinski [this message]
2025-04-10 15:23           ` Carolina Jubran
2025-04-10 23:16             ` Jakub Kicinski
2025-04-14  8:27               ` Carolina Jubran
2025-04-14 16:27                 ` Jakub Kicinski
2025-04-23  6:50                   ` Carolina Jubran
2025-04-30 12:12                     ` Carolina Jubran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250409150639.30a4c041@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).