From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next v2] net: airoha: Add matchall filter offload support
Date: Wed, 9 Apr 2025 16:37:37 -0700 [thread overview]
Message-ID: <20250409163737.2b6c13e3@kernel.org> (raw)
In-Reply-To: <20250409-airoha-hw-rx-ratelimit-v2-1-694e4fda5c91@kernel.org>
On Wed, 09 Apr 2025 01:15:32 +0200 Lorenzo Bianconi wrote:
> + airoha_fe_wr(eth, REG_PPE_DFT_CPORT0(0),
> + FIELD_PREP(DFT_CPORT_MASK(7), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(6), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(5), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM1) |
Coccicheck spotted that the previous line is duplicated..
> + FIELD_PREP(DFT_CPORT_MASK(3), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(2), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(1), FE_PSE_PORT_CDM1) |
> + FIELD_PREP(DFT_CPORT_MASK(0), FE_PSE_PORT_CDM1));
> + airoha_fe_wr(eth, REG_PPE_DFT_CPORT0(1),
> + FIELD_PREP(DFT_CPORT_MASK(7), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(6), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(5), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM2) |
.. and here.
> + FIELD_PREP(DFT_CPORT_MASK(3), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(2), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(1), FE_PSE_PORT_CDM2) |
> + FIELD_PREP(DFT_CPORT_MASK(0), FE_PSE_PORT_CDM2));
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-09 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 23:15 [PATCH net-next v2] net: airoha: Add matchall filter offload support Lorenzo Bianconi
2025-04-09 8:46 ` Davide Caratti
2025-04-09 23:37 ` Jakub Kicinski [this message]
2025-04-10 7:16 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409163737.2b6c13e3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).