Re: [PATCH net-next] io_uring/zcrx: enable tcp-data-split in selftest

[Jakub Kicinski <kuba@kernel.org>]

On Wed,  9 Apr 2025 09:31:53 -0700 David Wei wrote:
> For bnxt when the agg ring is used then tcp-data-split is automatically
> reported to be enabled, but __net_mp_open_rxq() requires tcp-data-split
> to be explicitly enabled by the user.

> diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.py b/tools/testing/selftests/drivers/net/hw/iou-zcrx.py
> index 9f271ab6ec04..6a0378e06cab 100755
> --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.py
> +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.py
> @@ -35,6 +35,7 @@ def test_zcrx(cfg) -> None:
>      rx_ring = _get_rx_ring_entries(cfg)
>  
>      try:
> +        ethtool(f"-G {cfg.ifname} tcp-data-split on", host=cfg.remote)

You should really use defer() to register the "undo" actions
individually. Something like:

         ethtool(f"-G {cfg.ifname} tcp-data-split on", host=cfg.remote)
         defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}", host=cfg.remote)
         ethtool(f"-G {cfg.ifname} rx 64", host=cfg.remote)
         defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}", host=cfg.remote)
         ethtool(f"-X {cfg.ifname} equal {combined_chans - 1}", host=cfg.remote)
         defer(ethtool, f"-X {cfg.ifname} default", host=cfg.remote)
         ...

This patch is fine. But could you follow up and convert the test fully?