From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFA212857FA; Thu, 10 Apr 2025 13:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292691; cv=none; b=gsXWqdWBDD1u+QDa/7UwbC+LZq6oj9Jf/PifRpubRfgIBzx0Uub7OeeURi+4EnVXcir/yHwS+JUDIGMXJq9jsdSZ+fh2r7tXdtWOHSMM2KzfAAHzp4Cuk1cXS71iwvuOPGCO451grG0QvdPlEVGNgmOf/Tio9rfeHJf1gD07xy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744292691; c=relaxed/simple; bh=zIuv99jR6/DvhIj/ezFd7gDXDCcqNb+1BR6FZTmkWrc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VaLPSk4WfSpZ4yvNBThlrE3Md7vZH1X3QchXS4mvpbSwS8riXxEfvO7JnI3yCsUBFbvIbBIcP/GBNU5Upqh5PBMC4CVwqcBS5mD54ye60mX4Pjz+CDsV2ZJEV5xpV8seVHuElfaJhjf6jFp73qZ4pjIQ5QobEPJ5uthTXIvTWu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WWFnvSEr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WWFnvSEr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C278C4CEE9; Thu, 10 Apr 2025 13:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744292690; bh=zIuv99jR6/DvhIj/ezFd7gDXDCcqNb+1BR6FZTmkWrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WWFnvSErJGHoAFL49fO2hww9SHO0/RHs5AH/HqVziawMjh9vkYSNexmYM9V1qao// Uh5m0IBGBkSMOyIl6LkSlHlAzZ8YKtLENE/p8M8TUsEKyGyM9YU4yx4VNGvR+vZpeJ myK2knY44CdZhmM1cF4cFbU8prSB9k9gCLko941gW1mDLOBdONOpcnJXQkkw0Nuzng SOBwpUziCkn/UNnqzHR0tQdkzSkfGkkBfztnfEcXBSOrSxMfFsR97hoDLizOpcrsJY nBHLyuWvuLHh2P7ENrjNiNabOB/jqF0W7PDRh3p6iblYP0qF5q//7SvENLREFz9+8M sxOCOcCxwnQcQ== Date: Thu, 10 Apr 2025 16:44:43 +0300 From: Leon Romanovsky To: Alexander Lobakin Cc: Larysa Zaremba , intel-wired-lan@lists.osuosl.org, Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Przemek Kitszel , Jiri Pirko , Tatyana Nikolova , Andrew Lunn , Michael Ellerman , Maciej Fijalkowski , Lee Trager , Madhavan Srinivasan , Sridhar Samudrala , Jacob Keller , Michal Swiatkowski , Mateusz Polchlopek , Ahmed Zaki , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Karlsson, Magnus" , Emil Tantilov , Madhu Chittim , Josh Hay , Milena Olech , pavan.kumar.linga@intel.com, "Singhai, Anjali" , Phani R Burra Subject: Re: [PATCH iwl-next 05/14] libeth: add control queue support Message-ID: <20250410134443.GS199604@unreal> References: <20250408124816.11584-1-larysa.zaremba@intel.com> <20250408124816.11584-6-larysa.zaremba@intel.com> <20250410082137.GO199604@unreal> <20250410112349.GP199604@unreal> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 10, 2025 at 03:05:19PM +0200, Alexander Lobakin wrote: > From: Leon Romanovsky > Date: Thu, 10 Apr 2025 14:23:49 +0300 > > > On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote: > >> On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote: > >>> On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote: > >>>> From: Phani R Burra > >>>> > >>>> Libeth will now support control queue setup and configuration APIs. > >>>> These are mainly used for mailbox communication between drivers and > >>>> control plane. > >>>> > >>>> Make use of the page pool support for managing controlq buffers. <...> > >> Module dependencies are as follows: > >> > >> libeth_rx and libeth_pci do not depend on other modules. > >> libeth_cp depends on both libeth_rx and libeth_pci. > >> idpf directly uses libeth_pci, libeth_rx and libeth_cp. > >> ixd directly uses libeth_cp and libeth_pci. > > > > You can do whatever module architecture for netdev devices, but if you > > plan to expose it to RDMA devices, I will vote against any deep layered > > module architecture for the drivers. > > No plans for RDMA there. > > Maybe link the whole kernel to one vmlinux then? It seems that you didn't understand at all about what we are talking here. Please use the opportunity that you are working for the same company with Larysa and ask her offline. She understood perfectly about which modules we are talking. > > > > > BTW, please add some Intel prefix to the modules names, they shouldn't > > be called in generic names like libeth, e.t.c > > Two modules with the same name can't exist within the kernel. libeth was > available and I haven't seen anyone wanting to take it. It's not common > at all to name a module starting with "lib". Again, please talk with Larysa. ETH part is problematic in libeth name and not LIB. Thanks