netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Cosmin Ratiu <cratiu@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"horms@kernel.org" <horms@kernel.org>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	"edumazet@google.com" <edumazet@google.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: net-shapers plan
Date: Thu, 10 Apr 2025 16:16:11 -0700	[thread overview]
Message-ID: <20250410161611.5321eb9f@kernel.org> (raw)
In-Reply-To: <2f747aac-767c-4631-b1db-436b11b83015@nvidia.com>

On Thu, 10 Apr 2025 18:23:56 +0300 Carolina Jubran wrote:
> We do configure the correct priority-to-queue mapping in the driver when 
> mqprio is used in DCB mode. In this setup, each traffic class has its 
> own dedicated Tx queue(s), and the driver programs the mapping 
> accordingly. The hardware performs its default priority check, sees that 
> the packet matches the configured queue, and proceeds to transmit 
> without taking any further action — everything behaves as expected.
> 
> When DCB mode is not enabled, there is no fixed mapping between traffic 
> classes and Tx queues. In this case, the hardware still performs the 
> check, and if it detects a mismatch, it moves the send queue to the 
> appropriate scheduling queue to maintain proper traffic class behavior.
> The priority check is always active by default, but when the mapping is 
> configured properly, it’s followed by a noop.

I hope you understand my concern, tho. Since you're providing the first
implementation, if the users can grow dependent on such behavior we'd
be in no position to explain later that it's just a quirk of mlx5 and
not how the API is intended to operate.

  reply	other threads:[~2025-04-10 23:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 14:03 net-shapers plan Cosmin Ratiu
2025-03-11  1:42 ` Samudrala, Sridhar
2025-03-12 11:02   ` Carolina Jubran
2025-03-11 13:38 ` Jiri Pirko
2025-03-26 15:55   ` Cosmin Ratiu
2025-03-28 12:13 ` Jakub Kicinski
2025-04-01  8:35   ` Carolina Jubran
2025-04-01 14:50     ` Jakub Kicinski
2025-04-08 14:43       ` Carolina Jubran
2025-04-09 22:06         ` Jakub Kicinski
2025-04-10 15:23           ` Carolina Jubran
2025-04-10 23:16             ` Jakub Kicinski [this message]
2025-04-14  8:27               ` Carolina Jubran
2025-04-14 16:27                 ` Jakub Kicinski
2025-04-23  6:50                   ` Carolina Jubran
2025-04-30 12:12                     ` Carolina Jubran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250410161611.5321eb9f@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).