From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Simon Horman" <horms@kernel.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>
Subject: Re: [PATCH net-next v5 1/4] net: ethtool: Introduce per-PHY DUMP operations
Date: Thu, 10 Apr 2025 17:21:55 -0700 [thread overview]
Message-ID: <20250410172155.3cd854d8@kernel.org> (raw)
In-Reply-To: <20250410123350.174105-2-maxime.chevallier@bootlin.com>
On Thu, 10 Apr 2025 14:33:46 +0200 Maxime Chevallier wrote:
> ethnl commands that target a phy_device need a DUMP implementation that
> will fill the reply for every PHY behind a netdev. We therefore need to
> iterate over the dev->topo to list them.
>
> When multiple PHYs are behind the same netdev, it's also useful to
> perform DUMP with a filter on a given netdev, to get the capability of
> every PHY.
>
> Implement dedicated genl ->start(), ->dumpit() and ->done() operations
> for PHY-targetting command, allowing filtered dumps and using a dump
> context that keep track of the PHY iteration for multi-message dump.
Transient warnings here that the new functions are not used :(
Would it work to squash the 3rd and 4th patches in?
Not ideal but better than having a warning.
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-11 0:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 12:33 [PATCH net-next v5 0/4] net: ethtool: Introduce ethnl dump helpers Maxime Chevallier
2025-04-10 12:33 ` [PATCH net-next v5 1/4] net: ethtool: Introduce per-PHY DUMP operations Maxime Chevallier
2025-04-11 0:21 ` Jakub Kicinski [this message]
2025-04-11 7:26 ` Maxime Chevallier
2025-04-12 1:52 ` Jakub Kicinski
2025-04-10 12:33 ` [PATCH net-next v5 2/4] net: ethtool: phy: Convert the PHY_GET command to generic phy dump Maxime Chevallier
2025-04-10 12:33 ` [PATCH net-next v5 3/4] net: ethtool: plca: Use per-PHY DUMP operations Maxime Chevallier
2025-04-10 12:33 ` [PATCH net-next v5 4/4] net: ethtool: pse-pd: " Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410172155.3cd854d8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).