From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next] io_uring/zcrx: enable tcp-data-split in selftest
Date: Thu, 10 Apr 2025 17:28:50 -0700 [thread overview]
Message-ID: <20250410172850.55752f0b@kernel.org> (raw)
In-Reply-To: <54a8a9fa-9717-435e-9253-40f3a0a7f779@davidwei.uk>
On Wed, 9 Apr 2025 19:06:13 -0700 David Wei wrote:
> > You should really use defer() to register the "undo" actions
> > individually. Something like:
> >
> > ethtool(f"-G {cfg.ifname} tcp-data-split on", host=cfg.remote)
> > defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}", host=cfg.remote)
> > ethtool(f"-G {cfg.ifname} rx 64", host=cfg.remote)
> > defer(ethtool, f"-G {cfg.ifname} rx {rx_ring}", host=cfg.remote)
> > ethtool(f"-X {cfg.ifname} equal {combined_chans - 1}", host=cfg.remote)
> > defer(ethtool, f"-X {cfg.ifname} default", host=cfg.remote)
> > ...
> >
> > This patch is fine. But could you follow up and convert the test fully?
>
> I'll send a follow up, one to switch to defer(), then another to call
> tcp-data-split on.
Thinking again this should go to net, rather than net-next.
I'll apply it now, but just letting you know that the follow up needs
to wait a week for trees to converge.
next prev parent reply other threads:[~2025-04-11 0:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 16:31 [PATCH net-next] io_uring/zcrx: enable tcp-data-split in selftest David Wei
2025-04-10 0:06 ` Jakub Kicinski
2025-04-10 2:06 ` David Wei
2025-04-11 0:28 ` Jakub Kicinski [this message]
2025-04-11 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410172850.55752f0b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).