From: Jakub Kicinski <kuba@kernel.org>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Shuah Khan <shuah@kernel.org>,
sd@queasysnail.net, ryazanov.s.a@gmail.com,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Xiao Liang <shaw.leon@gmail.com>
Subject: Re: [PATCH net-next v25 04/23] ovpn: keep carrier always on for MP interfaces
Date: Thu, 10 Apr 2025 20:03:25 -0700 [thread overview]
Message-ID: <20250410200325.5621a4f5@kernel.org> (raw)
In-Reply-To: <20250407-b4-ovpn-v25-4-a04eae86e016@openvpn.net>
On Mon, 07 Apr 2025 21:46:12 +0200 Antonio Quartulli wrote:
> + /* carrier for P2P interfaces is switched on and off when
> + * the peer is added or deleted.
> + *
> + * in case of P2MP interfaces we just keep the carrier always on
> + */
> + if (ovpn->mode == OVPN_MODE_MP)
> + netif_carrier_on(dev);
Any reason why you turn it during open rather than leaving it be before
registration? Now the link is down until first open, then it stays up
even if user closes?
next prev parent reply other threads:[~2025-04-11 3:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 19:46 [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel Offload (ovpn) Antonio Quartulli
2025-04-10 17:51 ` ALOK TIWARI
2025-04-11 8:47 ` Antonio Quartulli
2025-04-11 2:54 ` Jakub Kicinski
2025-04-11 8:04 ` Antonio Quartulli
2025-04-11 13:50 ` Sabrina Dubroca
2025-04-11 21:18 ` Jakub Kicinski
2025-04-14 13:39 ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 02/23] ovpn: add basic netlink support Antonio Quartulli
2025-04-10 18:26 ` ALOK TIWARI
2025-04-11 2:58 ` Jakub Kicinski
2025-04-11 8:06 ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 03/23] ovpn: add basic interface creation/destruction/management routines Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 04/23] ovpn: keep carrier always on for MP interfaces Antonio Quartulli
2025-04-11 3:03 ` Jakub Kicinski [this message]
2025-04-11 8:38 ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 05/23] ovpn: introduce the ovpn_peer object Antonio Quartulli
2025-04-10 18:49 ` ALOK TIWARI
2025-04-07 19:46 ` [PATCH net-next v25 06/23] ovpn: introduce the ovpn_socket object Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 07/23] ovpn: implement basic TX path (UDP) Antonio Quartulli
2025-04-11 3:07 ` Jakub Kicinski
2025-04-11 8:46 ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 08/23] ovpn: implement basic RX " Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 09/23] ovpn: implement packet processing Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 10/23] ovpn: store tunnel and transport statistics Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 11/23] ovpn: implement TCP transport Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 12/23] skb: implement skb_send_sock_locked_with_flags() Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 13/23] ovpn: add support for MSG_NOSIGNAL in tcp_sendmsg Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 14/23] ovpn: implement multi-peer support Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 15/23] ovpn: implement peer lookup logic Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 16/23] ovpn: implement keepalive mechanism Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 17/23] ovpn: add support for updating local or remote UDP endpoint Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 18/23] ovpn: implement peer add/get/dump/delete via netlink Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 19/23] ovpn: implement key add/get/del/swap " Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 20/23] ovpn: kill key and notify userspace in case of IV exhaustion Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 21/23] ovpn: notify userspace when a peer is deleted Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 22/23] ovpn: add basic ethtool support Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 23/23] testing/selftests: add test tool and scripts for ovpn module Antonio Quartulli
2025-04-08 6:34 ` [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload Jiri Slaby
2025-04-08 7:37 ` Antonio Quartulli
2025-04-10 14:03 ` Sabrina Dubroca
2025-04-10 14:16 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410200325.5621a4f5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sd@queasysnail.net \
--cc=shaw.leon@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).