From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEA69290BA8; Thu, 10 Apr 2025 20:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744318767; cv=none; b=Aldmg8EMXtnzxJYgJLvDP4lRjE3Vw2/SONx6Hq3YkjbQzsgmFEjT/k6SIVzHdLuD2tRkqg9OO2Wkw0Lj1oXeC+xf4GU33mJdb0SSQxUnrxmYKCil9OvBlnwTle7iPt6yNgbJEHbiLRzBixARo74ZKuCJInw3StejzU2WDIJQmtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744318767; c=relaxed/simple; bh=ecHUf2Hpwk+1O+STcd+2A4XQmIHogrxTQ9Qfsd65yEg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oUQlK+fqPzaJuiZViBB7zg0yFGjdzVmv9EL1LIoOnqXrAYHOAbFVpg/FKo+5yOMs3Di0Yt37UN5I3k+TJlTlwxv8GWrVSemXO/KKL8TfJrTA4qZe9mkoUM7D+vJ76YtjHW+SAEcRpXEx1E8YeA7ovmpP9++uLmy2ILpoIqIzNWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N1/YGJY5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N1/YGJY5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0591C4CEDD; Thu, 10 Apr 2025 20:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744318767; bh=ecHUf2Hpwk+1O+STcd+2A4XQmIHogrxTQ9Qfsd65yEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N1/YGJY5o59GBadahGD1tR89MMuhoDVyWrfwPbWC2WmIFRfkO1I3q7C1ionfou5gQ qw31+65qNcKO1aO7auRqDAIqq980sBsJrHIQwj3suyRosRcCKeSsfig1FGlb3bQtNA 67pQ9bInybrVNUa/bXoe0K6I/af3uzudSkAbXkKyY2srHwU8uSg7nc/Ta9puCNmxT0 dEJtM///RfVWw0t26NJIHXUpkFKiPp+LzEi/RPs2fMKWx0mz+y/z5QwHqp8VatCP0T c/c7l7Z/kOzy3HlkDypmFNu4c1WIyHZc9tkX6kmcc+6J1+RPLA35+EclYWjNJR4LLa uXJoN82QRWu0w== Date: Thu, 10 Apr 2025 15:59:25 -0500 From: Rob Herring To: Lukasz Majewski Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Cochran , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: Re: [net-next v4 1/5] dt-bindings: net: Add MTIP L2 switch description Message-ID: <20250410205925.GA1041840-robh@kernel.org> References: <20250407145157.3626463-1-lukma@denx.de> <20250407145157.3626463-2-lukma@denx.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250407145157.3626463-2-lukma@denx.de> On Mon, Apr 07, 2025 at 04:51:53PM +0200, Lukasz Majewski wrote: > This patch provides description of the MTIP L2 switch available in some > NXP's SOCs - e.g. imx287. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename the file to match exactly the compatible > (nxp,imx287-mtip-switch) > > Changes for v3: > - Remove '-' from const:'nxp,imx287-mtip-switch' > - Use '^port@[12]+$' for port patternProperties > - Drop status = "okay"; > - Provide proper indentation for 'example' binding (replace 8 > spaces with 4 spaces) > - Remove smsc,disable-energy-detect; property > - Remove interrupt-parent and interrupts properties as not required > - Remove #address-cells and #size-cells from required properties check > - remove description from reg: > - Add $ref: ethernet-switch.yaml# > > Changes for v4: > - Use $ref: ethernet-switch.yaml#/$defs/ethernet-ports and remove already > referenced properties > - Rename file to nxp,imx28-mtip-switch.yaml > --- > .../bindings/net/nxp,imx28-mtip-switch.yaml | 126 ++++++++++++++++++ > 1 file changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml > > diff --git a/Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml b/Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml > new file mode 100644 > index 000000000000..1afaf8029725 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nxp,imx28-mtip-switch.yaml > @@ -0,0 +1,126 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nxp,imx28-mtip-switch.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP switch) > + > +maintainers: > + - Lukasz Majewski > + > +description: > + The 2-port switch ethernet subsystem provides ethernet packet (L2) > + communication and can be configured as an ethernet switch. It provides the > + reduced media independent interface (RMII), the management data input > + output (MDIO) for physical layer device (PHY) management. > + > +$ref: ethernet-switch.yaml#/$defs/ethernet-ports > + > +patternProperties: > + "^(ethernet-)?ports$": New bindings should only use 'ethernet-ports'. > + type: object > + additionalProperties: true But what's this for? I thought you had some constrants for phy-mode and phy-handle? > + > +properties: > + compatible: > + const: nxp,imx28-mtip-switch > + > + reg: > + maxItems: 1 > + > + phy-supply: > + description: > + Regulator that powers Ethernet PHYs. > + > + clocks: > + items: > + - description: Register accessing clock > + - description: Bus access clock > + - description: Output clock for external device - e.g. PHY source clock > + - description: IEEE1588 timer clock > + > + clock-names: > + items: > + - const: ipg > + - const: ahb > + - const: enet_out > + - const: ptp > + > + interrupts: > + items: > + - description: Switch interrupt > + - description: ENET0 interrupt > + - description: ENET1 interrupt > + > + pinctrl-names: true > + > + mdio: > + type: object > + $ref: mdio.yaml# > + unevaluatedProperties: false > + description: > + Specifies the mdio bus in the switch, used as a container for phy nodes. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - mdio > + - ethernet-ports > + > +additionalProperties: false unevaluatedProperties: false > + > +examples: > + - | > + #include > + switch@800f0000 { > + compatible = "nxp,imx28-mtip-switch"; > + reg = <0x800f0000 0x20000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&mac0_pins_a>, <&mac1_pins_a>; > + phy-supply = <®_fec_3v3>; > + interrupts = <100>, <101>, <102>; > + clocks = <&clks 57>, <&clks 57>, <&clks 64>, <&clks 35>; > + clock-names = "ipg", "ahb", "enet_out", "ptp"; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mtip_port1: ethernet-port@1 { > + reg = <1>; > + label = "lan0"; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + phy-mode = "rmii"; > + phy-handle = <ðphy0>; > + }; > + > + mtip_port2: ethernet-port@2 { > + reg = <2>; > + label = "lan1"; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + phy-mode = "rmii"; > + phy-handle = <ðphy1>; > + }; > + }; > + > + mdio_sw: mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&gpio2 13 0>; > + reset-delay-us = <25000>; > + reset-post-delay-us = <10000>; > + > + ethphy0: ethernet-phy@0 { > + reg = <0>; > + }; > + > + ethphy1: ethernet-phy@1 { > + reg = <1>; > + }; > + }; > + }; > -- > 2.39.5 >