From: Lee Jones <lee@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Tobias Junghans <tobias.junghans@inhub.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-leds@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] leds: trigger: netdev: Match net in netdev_trig_notify()
Date: Fri, 11 Apr 2025 08:44:21 +0100 [thread overview]
Message-ID: <20250411074421.GV372032@google.com> (raw)
In-Reply-To: <45822bb5-a408-42c1-85b7-e179789d586a@lunn.ch>
On Thu, 10 Apr 2025, Andrew Lunn wrote:
> On Thu, Apr 10, 2025 at 11:17:59AM +0100, Lee Jones wrote:
> > Andrew et al., please could you verify for sanity?
>
> Sorry, i did not see this before.
>
> Maybe we need a new MAINTAINER entry for
> drivers/leds/triggers/ledtrig-timer.c which points to the netdev list?
I assume you mean:
drivers/leds/trigger/ledtrig-netdev.c
In which case, sure, I'm all for that.
Add it to your MAINTAINERS entry and I will Ack it.
> Humm:
>
> ./scripts/get_maintainer.pl drivers/leds/trigger/ledtrig-netdev.c
> Lee Jones <lee@kernel.org> (maintainer:LED SUBSYSTEM,commit_signer:4/4=100%)
> Pavel Machek <pavel@kernel.org> (maintainer:LED SUBSYSTEM)
> Andrew Lunn <andrew@lunn.ch> (commit_signer:2/4=50%)
> Marek Vasut <marex@denx.de> (commit_signer:2/4=50%,authored:2/4=50%,added_lines:15/36=42%,removed_lines:3/8=38%)
> Heiner Kallweit <hkallweit1@gmail.com> (commit_signer:1/4=25%,authored:1/4=25%,removed_lines:2/8=25%)
> Lukasz Majewski <lukma@denx.de> (commit_signer:1/4=25%,authored:1/4=25%,added_lines:21/36=58%,removed_lines:3/8=38%)
> linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
>
> So i should of been Cc:ed.
To be fair to the contributor, I don't always add commit signers either.
> Network names spaces and files in /sysfs probably need netdev
> involved, in order to get a good review.
Definitely.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-04-11 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250404151042.GC372032@google.com>
[not found] ` <20250407090455.677846-1-tobias.junghans@inhub.de>
2025-04-10 10:17 ` [PATCH v2] leds: trigger: netdev: Match net in netdev_trig_notify() Lee Jones
2025-04-10 20:39 ` Andrew Lunn
2025-04-11 7:44 ` Lee Jones [this message]
2025-04-23 13:13 ` [PATCH v2] leds: trigger: netdev: refactor dev matching " Tobias Junghans
2025-04-24 8:09 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411074421.GV372032@google.com \
--to=lee@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias.junghans@inhub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).