netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, Salvatore Bonaccorso <carnil@debian.org>,
	asciiwolf@seznam.cz, Petter Reinholdtsen <pere@hungry.com>
Subject: [PATCH ethtool] Set type property to console-application for provided AppStream metainfo XML
Date: Fri, 11 Apr 2025 16:10:24 +0200	[thread overview]
Message-ID: <20250411141023.14356-2-carnil@debian.org> (raw)

As pointed out in the Debian downstream report, as ethtool is a
command-line tool the XML root myst have the type property set to
console-application.

Additionally with the type propety set to desktop, ethtool is user
uninstallable via GUI (such as GNOME Software or KDE Discover).

Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
Reported-by: asciiwolf@seznam.cz
Cc: Petter Reinholdtsen <pere@hungry.com>
Link: https://bugs.debian.org/1102647
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2359069
Link: https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 org.kernel.software.network.ethtool.metainfo.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
index efe84c17e4cd..c31cae4bede6 100644
--- a/org.kernel.software.network.ethtool.metainfo.xml
+++ b/org.kernel.software.network.ethtool.metainfo.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
-- 
2.49.0


             reply	other threads:[~2025-04-11 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 14:10 Salvatore Bonaccorso [this message]
2025-04-11 21:31 ` [PATCH ethtool] Set type property to console-application for provided AppStream metainfo XML Salvatore Bonaccorso
2025-04-12  4:26   ` Petter Reinholdtsen
2025-04-12  5:35     ` Salvatore Bonaccorso
2025-04-12  8:39       ` Petter Reinholdtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250411141023.14356-2-carnil@debian.org \
    --to=carnil@debian.org \
    --cc=asciiwolf@seznam.cz \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=pere@hungry.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).