From: Jakub Kicinski <kuba@kernel.org>
To: syzbot <syzbot+4ebb06d5f6e3597279c0@syzkaller.appspotmail.com>
Cc: andrii@kernel.org, ast@kernel.org, bjorn@kernel.org,
bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net,
edumazet@google.com, horms@kernel.org, jonathan.lemon@gmail.com,
linux-kernel@vger.kernel.org, maciej.fijalkowski@intel.com,
magnus.karlsson@intel.com, netdev@vger.kernel.org,
pabeni@redhat.com, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] [bpf?] possible deadlock in xsk_diag_dump
Date: Fri, 11 Apr 2025 15:38:22 -0700 [thread overview]
Message-ID: <20250411153822.2ff97d57@kernel.org> (raw)
In-Reply-To: <67f50e3f.050a0220.396535.0562.GAE@google.com>
On Tue, 08 Apr 2025 04:53:35 -0700 syzbot wrote:
> Chain exists of:
> &xs->mutex --> &rdev->wiphy.mtx --> &net->xdp.lock
>
> Possible unsafe locking scenario:
>
> CPU0 CPU1
> ---- ----
> lock(&net->xdp.lock);
> lock(&rdev->wiphy.mtx);
> lock(&net->xdp.lock);
> lock(&xs->mutex);
After looking at it with Stanislav our best guess is that we're mixing
normal and ops locked devices in close_many. Will send a fix over the
weekend.
prev parent reply other threads:[~2025-04-11 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 11:53 [syzbot] [net?] [bpf?] possible deadlock in xsk_diag_dump syzbot
2025-04-11 22:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411153822.2ff97d57@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+4ebb06d5f6e3597279c0@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).