netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Thangaraj Samynathan <thangaraj.s@microchip.com>
Cc: netdev@vger.kernel.org, bryan.whitehead@microchip.com,
	UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix memory allocation failure
Date: Fri, 11 Apr 2025 17:53:53 +0100	[thread overview]
Message-ID: <20250411165353.GN395307@horms.kernel.org> (raw)
In-Reply-To: <20250410041034.17423-1-thangaraj.s@microchip.com>

On Thu, Apr 10, 2025 at 09:40:34AM +0530, Thangaraj Samynathan wrote:
> The driver allocates ring elements using GFP_DMA flags. There is
> no dependency from LAN743x hardware on memory allocation should be
> in DMA_ZONE. Hence modifying the flags to use only GFP_ATOMIC
> 
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
> ---
> v0
> -Initial Commit
> 
> v1
> -Modified GFP flags from GFP_KERNEL to GFP_ATOMIC
> -added fixes tag
> 
> v2
> -Resubmit net-next instead of net

Hi Thangaraj,

Thanks for the update. And sorry for not noticing this
in my earlier review. But I have some more feedback:

* I don't think it is correct to refer to this as fixing a failure
  in the subject.

* I do think the subject prefix can be shortened to 'net: lan743x: '



Perhaps something more like this?

	[PATCH net-next v3] net: lan743x: Allocate rings outside ZONE_DMA

And perhaps also mention in the commit message that this
is consistent with the other caller of lan743x_rx_init_ring_element().

Thanks!

  reply	other threads:[~2025-04-11 16:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  4:10 [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix memory allocation failure Thangaraj Samynathan
2025-04-11 16:53 ` Simon Horman [this message]
2025-04-15  4:53   ` Rengarajan.S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250411165353.GN395307@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bryan.whitehead@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thangaraj.s@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).