From: Simon Horman <horms@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: andrew+netdev@lunn.ch, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, michal.swiatkowski@linux.intel.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net 3/5] pds_core: handle unsupported PDS_CORE_CMD_FW_CONTROL result
Date: Fri, 11 Apr 2025 20:00:25 +0100 [thread overview]
Message-ID: <20250411190025.GQ395307@horms.kernel.org> (raw)
In-Reply-To: <20250411003209.44053-4-shannon.nelson@amd.com>
On Thu, Apr 10, 2025 at 05:32:07PM -0700, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@amd.com>
>
> If the FW doesn't support the PDS_CORE_CMD_FW_CONTROL command
> the driver might at the least print garbage and at the worst
> crash when the user runs the "devlink dev info" devlink command.
>
> This happens because the stack variable fw_list is not 0
> initialized which results in fw_list.num_fw_slots being a
> garbage value from the stack. Then the driver tries to access
> fw_list.fw_names[i] with i >= ARRAY_SIZE and runs off the end
> of the array.
>
> Fix this by initializing the fw_list and by not failing
> completely if the devcmd fails because other useful information
> is printed via devlink dev info even if the devcmd fails.
>
> Fixes: 45d76f492938 ("pds_core: set up device and adminq")
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-11 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 0:32 [PATCH v2 net 0/5] pds_core: updates and fixes Shannon Nelson
2025-04-11 0:32 ` [PATCH v2 net 1/5] pds_core: Prevent possible adminq overflow/stuck condition Shannon Nelson
2025-04-11 18:59 ` Simon Horman
2025-04-11 0:32 ` [PATCH v2 net 2/5] pds_core: remove extra name description Shannon Nelson
2025-04-15 0:36 ` Jakub Kicinski
2025-04-15 23:15 ` Nelson, Shannon
2025-04-11 0:32 ` [PATCH v2 net 3/5] pds_core: handle unsupported PDS_CORE_CMD_FW_CONTROL result Shannon Nelson
2025-04-11 19:00 ` Simon Horman [this message]
2025-04-11 0:32 ` [PATCH v2 net 4/5] pds_core: Remove unnecessary check in pds_client_adminq_cmd() Shannon Nelson
2025-04-11 0:32 ` [PATCH v2 net 5/5] pds_core: make wait_context part of q_info Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411190025.GQ395307@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).