From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net 1/2] net: bridge: switchdev: do not notify new brentries as changed
Date: Mon, 14 Apr 2025 15:58:54 +0300 [thread overview]
Message-ID: <20250414125854.gtong53wmctv5pda@skbuf> (raw)
In-Reply-To: <CAOiHx=kRUE8_-4q6wOytrZObyyeSBMTHRMhaFGWDAJ-KBq5vFA@mail.gmail.com>
On Mon, Apr 14, 2025 at 02:11:18PM +0200, Jonas Gorski wrote:
> On Mon, Apr 14, 2025 at 1:39 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> > > $ ip link add swbridge type bridge vlan_filtering 1 vlan_default_pvid 1
>
> as mentioned for the cover letter, I will fix the example to use
> default_pvid 0 to have a "working" example.
Please do so. You have consistently given examples with vlan_default_pvid 1
throughout the patch set.
> Will add it. And I did check that, even considered shortly to merge this to
>
> if (becomes_brentry || would_change)
> *changed = true;
>
> but then considered that a refactoring too much.
I agree that it would be an unnecessary change for 'net'. You can send a
refactoring patch for net-next after Thursday, though.
next prev parent reply other threads:[~2025-04-14 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 12:24 [PATCH RFC net 0/2] net: dsa: fix handling brentry vlans with flags Jonas Gorski
2025-04-12 12:24 ` [PATCH RFC net 1/2] net: bridge: switchdev: do not notify new brentries as changed Jonas Gorski
2025-04-14 11:39 ` Vladimir Oltean
2025-04-14 12:11 ` Jonas Gorski
2025-04-14 12:58 ` Vladimir Oltean [this message]
2025-04-12 12:24 ` [PATCH RFC net 2/2] net: dsa: propagate brentry flag changes Jonas Gorski
2025-04-14 12:49 ` Vladimir Oltean
2025-04-14 12:52 ` Vladimir Oltean
2025-04-14 13:49 ` Jonas Gorski
2025-04-14 15:07 ` Vladimir Oltean
2025-04-19 10:52 ` Jonas Gorski
2025-04-28 10:07 ` Vladimir Oltean
2025-04-12 13:34 ` [PATCH RFC net 0/2] net: dsa: fix handling brentry vlans with flags Vladimir Oltean
2025-04-12 13:50 ` Jonas Gorski
2025-04-13 9:25 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414125854.gtong53wmctv5pda@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox