From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97B3129A3E7 for ; Tue, 15 Apr 2025 10:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744714104; cv=none; b=THMNuWT0e1gUVpTek1fVb6pWUNdTXVygk3BI/QZpKgh1jJdI6YFRy0f91VYhYaFNJf80UZ7ChK0vVr8pzGeRe/Sg2TaC19kSUv6r15t2ftMzbcB7ukU+xxiH8TApk9JcLy8JPU+yXvK5fBPqlI0IlKrS6flVdocWzc+KUr5vIPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744714104; c=relaxed/simple; bh=zRD5tQgoBa8pKK1axpkrKbW3Kb+medqh4znnI+U9QEQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JYgLczquPbwIOgoiVfZMNcheBbSbeZvjCLXPa6Fp76IiaIwCT3rR9lPDI0W+h5TzbCCHiBM57J1hVVD20i1Vw5bCmy+Xq3EqSpYEkt5WxeYKivRe23gHUCLRfRY/ZwADI08I2p9bgeGQd0L0ELRMIJfy8ad4sohANqV4AcnB08Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ObcvX56M; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ObcvX56M" Received: by mail.gandi.net (Postfix) with ESMTPSA id EE0541FCF2; Tue, 15 Apr 2025 10:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1744714099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=izSPy9yN5eadW5G0HXPfjkBbOQOu24hDdeaTSQaukE4=; b=ObcvX56MZ0k9lGklXRSsumGr3d6Q2N9qZNknU+xGzaQEh/9/n7F0JIcgXEseF8HSX0jEiX sR97CSdk8GVNDaWvSeeHJTZw8VtHRHZV/F98Y47kwA2UccLMXi8RAiRNS7Kqw5baAbunRi Od6O+Cs4TZPq13kYRPRTyFGZSjTE6NwkvdtsDV5HzC63NaQHi/KMIdSLCPnfH4I4B9datU /jd+GYFEJ6C9fkglfF5bAPx27cgqEhoRTTg0W2t6blVkMVX6K9z7736NgDavd+IlpuvOA9 zMCnRher3BipFMGTfhXK0PIA9Sp4Zr84gAChBb9zd4O1OfjhijETYNN5tmOlaA== Date: Tue, 15 Apr 2025 12:48:16 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , Chen-Yu Tsai , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Samuel Holland Subject: Re: [PATCH net-next] net: stmmac: sun8i: use stmmac_pltfr_probe() Message-ID: <20250415124816.1a420410@fedora.home> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdefvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpeforgigihhmvgcuvehhvghvrghllhhivghruceomhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeevledtvdevueehhfevhfelhfekveeftdfgiedufeffieeltddtgfefuefhueeknecukfhppedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjedphhgvlhhopehfvgguohhrrgdrhhhomhgvpdhmrghilhhfrhhomhepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudejpdhrtghpthhtoheprhhmkhdokhgvrhhnvghlsegrrhhmlhhinhhugidrohhrghdruhhkpdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohephhhkrghllhifvghithdusehgmhgrihhlrdgto hhmpdhrtghpthhtoheprghlvgigrghnughrvgdrthhorhhguhgvsehfohhsshdrshhtrdgtohhmpdhrtghpthhtoheprghnughrvgifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopeifvghnshestghsihgvrdhorhhgpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhm X-GND-Sasl: maxime.chevallier@bootlin.com Hi Russell, On Tue, 15 Apr 2025 11:15:53 +0100 "Russell King (Oracle)" wrote: > Using stmmac_pltfr_probe() simplifies the probe function. This will not > only call plat_dat->init (sun8i_dwmac_init), but also plat_dat->exit > (sun8i_dwmac_exit) appropriately if stmmac_dvr_probe() fails. This > results in an overall simplification of the glue driver. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Maxime Chevallier Maxime