From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099BA28466A for ; Tue, 15 Apr 2025 10:49:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744714186; cv=none; b=NWXytYlst8F4UhXE/isZCYmzzt68w6l3feuRnqp6kB8qJwawrKxsr6FMZAMy/ascNYzRZtyGgmLOw2eKUSXlOelL9ZIVt9I47t5ax36iIK7kbAVuZxqLvNUEjldnQDXbUQRtOpxiwQBnmk3/eGOa2ZLyY3XM+dU4RcEpqAgSMMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744714186; c=relaxed/simple; bh=lZ6ZD8YjCJDiYLaoN7sKeU9/LBEr+rc4Wbtcb6pSU9Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DyheT4CM9PZLeBD8GeFK3m2w8GhHhRlD+aE2wl90VBZz2Rqj9uHRz48XZB0sMgo3PKVf2MO0r5iu9gUqxq2YK/hXoKITHVaShv4EIJdCWXOElMCswIk3xvK4QPtUw6nFZXGDWg/RsmnLEEEn6yBzmX7z3zXdgUffxTjmcxiSwzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=MDUgUrep; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MDUgUrep" Received: by mail.gandi.net (Postfix) with ESMTPSA id 06B7C43A00; Tue, 15 Apr 2025 10:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1744714181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0N8WD8ywfUvrU/d+2liuajqPtuWQTIU1VEjQw4mowcs=; b=MDUgUrep2bya+Ae2MY+P/jZfBTqS7MKtncABP9KbI61wHb8SCV4zPpY0DoaX9hDHLNSPdg LWM33hudSBVhbw9c0d00bDgWOf+n0/eXmpeclVKQFWjiWjsstNLNtsqFnV+KsE55ZtBb3Q BFb6E1CuVjsBprIrd7dL0bOGQWC20Mq830LB1ZD9/55O1RGyMKsElp27ox9aV1wPiewDYL DPa1HikV2EZwytaSFasTSwQUsq4NGIpkkf4sxQJvbYmVJED0daDrM5/WuYyXiCFF6TyQqT a1o2/qXVvAuJ6V6fs6CfS14pQV2P3KbTb28ytX83Rji3KKHiCqfSzBDDFbTE1w== Date: Tue, 15 Apr 2025 12:49:38 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next] net: stmmac: intel: remove unnecessary setting max_speed Message-ID: <20250415124938.3e4682bb@fedora.home> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdefvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpeforgigihhmvgcuvehhvghvrghllhhivghruceomhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeevledtvdevueehhfevhfelhfekveeftdfgiedufeffieeltddtgfefuefhueeknecukfhppedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjedphhgvlhhopehfvgguohhrrgdrhhhomhgvpdhmrghilhhfrhhomhepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudefpdhrtghpthhtoheprhhmkhdokhgvrhhnvghlsegrrhhmlhhinhhugidrohhrghdruhhkpdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohephhhkrghllhifvghithdusehgmhgrihhlrdgto hhmpdhrtghpthhtoheprghlvgigrghnughrvgdrthhorhhguhgvsehfohhsshdrshhtrdgtohhmpdhrtghpthhtoheprghnughrvgifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomhdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhg X-GND-Sasl: maxime.chevallier@bootlin.com Hello Russell, On Tue, 15 Apr 2025 11:13:55 +0100 "Russell King (Oracle)" wrote: > Phylink will already limit the MAC speed according to the interface, > so if 2500BASE-X is selected, the maximum speed will be 2.5G. > Similarly, if SGMII is selected, the maximum speed will be 1G. > It is, therefore, not necessary to set a speed limit. Remove setting > plat_dat->max_speed from this glue driver. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Maxime Chevallier Maxime