From: Simon Horman <horms@kernel.org>
To: Sathesh B Edara <sedara@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hgani@marvell.com, vimleshk@marvell.com,
Veerasenareddy Burru <vburru@marvell.com>,
Shinas Rasheed <srasheed@marvell.com>,
Satananda Burla <sburla@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue
Date: Tue, 15 Apr 2025 19:44:48 +0100 [thread overview]
Message-ID: <20250415184448.GF395307@horms.kernel.org> (raw)
In-Reply-To: <20250414091856.18765-1-sedara@marvell.com>
On Mon, Apr 14, 2025 at 02:18:55AM -0700, Sathesh B Edara wrote:
> Address the netdevice usage count problem in the following scenarios:
> - When the interface is down
> - During transmit queue timeouts
Hi Sathesh,
I think it would be useful to include a bit more information in
the commit message describing:
1. Why these references were added / why they are not needed there
2. Why this can lead to incorrect reference counts end up being incorrect
in the two scenarios you mention above
Thanks!
>
> Fixes: cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization")
> Signed-off-by: Sathesh B Edara <sedara@marvell.com>
...
--
pw-bot: changes-requested
prev parent reply other threads:[~2025-04-15 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 9:18 [PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue Sathesh B Edara
2025-04-15 18:44 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415184448.GF395307@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hgani@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).