[PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue

[PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue

[Sathesh B Edara]

Address the netdevice usage count problem in the following scenarios:
- When the interface is down
- During transmit queue timeouts

Fixes: cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization")
Signed-off-by: Sathesh B Edara <sedara@marvell.com>
---
Changes:
V2:
  - Removed redundant call

 drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
index 18c922dd5fc6..5d033bc66bdf 100644
--- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
@@ -819,7 +819,6 @@ static void octep_vf_tx_timeout_task(struct work_struct *work)
 		octep_vf_open(netdev);
 	}
 	rtnl_unlock();
-	netdev_put(netdev, NULL);
 }
 
 /**
@@ -834,7 +833,6 @@ static void octep_vf_tx_timeout(struct net_device *netdev, unsigned int txqueue)
 {
 	struct octep_vf_device *oct = netdev_priv(netdev);
 
-	netdev_hold(netdev, NULL, GFP_ATOMIC);
 	schedule_work(&oct->tx_timeout_task);
 }
 
-- 
2.36.0

Re: [PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue

[Simon Horman]

On Mon, Apr 14, 2025 at 02:18:55AM -0700, Sathesh B Edara wrote:
> Address the netdevice usage count problem in the following scenarios:
> - When the interface is down
> - During transmit queue timeouts

Hi Sathesh,

I think it would be useful to include a bit more information in
the commit message describing:

1. Why these references were added / why they are not needed there
2. Why this can lead to incorrect reference counts end up being incorrect
   in the two scenarios you mention above

Thanks!

> 
> Fixes: cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization")
> Signed-off-by: Sathesh B Edara <sedara@marvell.com>

...

-- 
pw-bot: changes-requested