From: Simon Horman <horms@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com
Subject: Re: [PATCH net] eth: bnxt: fix missing ring index trim on error path
Date: Wed, 16 Apr 2025 13:03:12 +0100 [thread overview]
Message-ID: <20250416120312.GP395307@horms.kernel.org> (raw)
In-Reply-To: <CACKFLikF5SY6MaDS97G7Vg0+tZeGR3cKOimsm+ra7Cg+msXYkg@mail.gmail.com>
On Mon, Apr 14, 2025 at 09:35:54AM -0700, Michael Chan wrote:
> On Mon, Apr 14, 2025 at 7:32 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > Commit under Fixes converted tx_prod to be free running but missed
> > masking it on the Tx error path. This crashes on error conditions,
> > for example when DMA mapping fails.
> >
> > Fixes: 6d1add95536b ("bnxt_en: Modify TX ring indexing logic.")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Thanks.
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
FTR this now appears in net as
commit 12f2d033fae9 ("eth: bnxt: fix missing ring index trim on error path")
prev parent reply other threads:[~2025-04-16 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 14:32 [PATCH net] eth: bnxt: fix missing ring index trim on error path Jakub Kicinski
2025-04-14 16:35 ` Michael Chan
2025-04-16 12:03 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416120312.GP395307@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).