From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CD9BA34 for ; Thu, 17 Apr 2025 00:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744848793; cv=none; b=lwYlTYm/1172pFXaQdfRgpMx4HoQCFdTvTbHKGQKsDM7mVGBJrpJ/gQEs/dvCGdUMogaW2SWjMRZ6msfVclMw80MCNNOaKPFMF3OMDPXFD0EeziOZmD/KcmKCQRLFTYMkVUANuspPscCRTIUvLV+zO0gAv80Lj6eUi0XYNpnOWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744848793; c=relaxed/simple; bh=6SjWXyZeZ7k56pWGMKnGwNYjc5GwbN6XrG18Hplr6Bs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nD9h0drwCn9vMxrOUCO0q9seaSrraKb7ByNohNKq6Ll2lqzfv/W4eMw8ndzju+SbCW4EyiSbnwI3OUxXkfcTkWjT6qPAwEVI8dQvjkWbXQfMyvUiHlNMME167Mgv/QGawbKy6DV69VW2qstpCgKco4yJ8kVMSJV9cdf0ltZP9+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QXEavcoD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QXEavcoD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DD50C4CEE2; Thu, 17 Apr 2025 00:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744848792; bh=6SjWXyZeZ7k56pWGMKnGwNYjc5GwbN6XrG18Hplr6Bs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QXEavcoDyiRCE8Oe3BYIEQEl1xn2S9aSNUoBbbG8U05ZfAClSvQL6VG4onUpafULf haqlEocegnyxKjIBG8UPoeoj5uA7sh0zC59OVou3dtKInnna1YIElRgANpJkhGoG3k 1aTG6v5lCaRRb8uQHppNys0+/NE7YTfUckmOJe3+Y8LQgiZIYEcan1W0od3/3xJQrB 3k6NAEQE1HhWhh00zFU+5DKAp/tUWf722blWRQVamKooWOgXpRyWf/TNQ3rqTNvl1d sqTZNdN0E4gA2Yu/yyhFUBA02zunWTlr7RTP2bSdARNaEzjN9q2BpGpYR+1qwunn63 sPm2FM38NMN1A== Date: Wed, 16 Apr 2025 17:13:11 -0700 From: Jakub Kicinski To: "Keller, Jacob E" Cc: Jaroslav Pulchart , "Kitszel, Przemyslaw" , "Damato, Joe" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "Nguyen, Anthony L" , Igor Raits , Daniel Secik , Zdenek Pesek , "Dumazet, Eric" , Martin Karsten , "Zaki, Ahmed" , "Czapnik, Lukasz" , "Michal Swiatkowski" Subject: Re: [Intel-wired-lan] Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad) Message-ID: <20250416171311.30b76ec1@kernel.org> In-Reply-To: References: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com> <20250415175359.3c6117c9@kernel.org> <20250416064852.39fd4b8f@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 16 Apr 2025 22:57:10 +0000 Keller, Jacob E wrote: > > > And you're reverting just and exactly 492a044508ad13 ? > > > The memory for persistent config is allocated in alloc_netdev_mqs() > > > unconditionally. I'm lost as to how this commit could make any > > > difference :( > > > > Yes, reverted the 492a044508ad13. > > Struct napi_config *is* 1056 bytes You're probably looking at 6.15-rcX kernels. Yes, the affinity mask can be large depending on the kernel config. But report is for 6.13, AFAIU. In 6.13 and 6.14 napi_config was tiny.