[PATCH] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller

[PATCH] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller

[zhoubowen]

Add device IDs for Hygon 10Gb Ethernet controller.

Signed-off-by: zhoubowen <zhoubowen@kylinsec.com.cn>
---
 drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
index f409d7bd1f1e..206ff2e9e3cb 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
@@ -510,6 +510,10 @@ static const struct pci_device_id xgbe_pci_table[] = {
 	  .driver_data = (kernel_ulong_t)&xgbe_v2a },
 	{ PCI_VDEVICE(AMD, 0x1459),
 	  .driver_data = (kernel_ulong_t)&xgbe_v2b },
+	{ PCI_VDEVICE(HYGON, 0x1458),
+	  .driver_data = (kernel_ulong_t)&xgbe_v2a },
+	{ PCI_VDEVICE(HYGON, 0x1459),
+	  .driver_data = (kernel_ulong_t)&xgbe_v2b },
 	/* Last entry must be zero */
 	{ 0, }
 };
-- 
2.27.0

Re: [PATCH] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller

[Simon Horman]

On Tue, Apr 15, 2025 at 09:20:06PM +0800, zhoubowen wrote:
> Add device IDs for Hygon 10Gb Ethernet controller.

Am I correct in assuming that with this change in place these devices
function correctly with this driver without further modification to it?

> Signed-off-by: zhoubowen <zhoubowen@kylinsec.com.cn>

Please consider adding a space between your first and family name,
and capitalising each name in the Signed-off-by and From of
the patch. e.g. Zhou Bowen

Re: [PATCH] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller

[Zhou Bowen]

Hi Simon,

Thank you for reviewing the patch!

>On Tue, Apr 15, 2025 at 09:20:06PM +0800, zhoubowen wrote:
>> Add device IDs for Hygon 10Gb Ethernet controller.
>
>Am I correct in assuming that with this change in place these devices
>function correctly with this driver without further modification to it?
>

Yes, this patch has been validated on the Hygon C86-3G platform with the on-board 10GbE NIC.
It works properly (link up/down, data transfer, etc.) without any additional modifications.

>> Signed-off-by: zhoubowen <zhoubowen@kylinsec.com.cn>
>
>Please consider adding a space between your first and family name,
>and capitalising each name in the Signed-off-by and From of
>the patch. e.g. Zhou Bowen

Thanks for your comments, I will fix it,and the corresponding patch will be reissued next time.

--
Best regards,
Zhou Bowen

---

[PATCH v1] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller

[Zhou Bowen]

Add device IDs for Hygon 10Gb Ethernet controller.

Signed-off-by: Zhou Bowen <zhoubowen@kylinsec.com.cn>
---
 drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
index f409d7bd1f1e..206ff2e9e3cb 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
@@ -510,6 +510,10 @@ static const struct pci_device_id xgbe_pci_table[] = {
 	  .driver_data = (kernel_ulong_t)&xgbe_v2a },
 	{ PCI_VDEVICE(AMD, 0x1459),
 	  .driver_data = (kernel_ulong_t)&xgbe_v2b },
+	{ PCI_VDEVICE(HYGON, 0x1458),
+	  .driver_data = (kernel_ulong_t)&xgbe_v2a },
+	{ PCI_VDEVICE(HYGON, 0x1459),
+	  .driver_data = (kernel_ulong_t)&xgbe_v2b },
 	/* Last entry must be zero */
 	{ 0, }
 };
-- 
2.27.0

[PATCH WITHDRAW] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller

[Zhou Bowen]

Hi all,

I would like to formally withdraw the following patch due to a possible conflict
with Hygon product using in the future :

Subject: [PATCH] amd-xgbe: Add device IDs for Hygon 10Gb ethernet controller
Message-ID: <20250415132006.11268-1-zhoubowen@kylinsec.com.cn>

Apologies for the confusion and thank you for your understanding.

---
Best regards,
Zhou Bowen